| Message ID | 20221220104625.80667-10-hchauhan@ventanamicro.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Split region permissions into M-mode and SU-mode | expand |
On Tue, Dec 20, 2022 at 4:17 PM Himanshu Chauhan <hchauhan@ventanamicro.com> wrote: > > Updated the various permissions bits available for domains > defined in DT node and restrictions on them. > > Signed-off-by: Himanshu Chauhan <hchauhan@ventanamicro.com> > --- > docs/domain_support.md | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/docs/domain_support.md b/docs/domain_support.md > index 8963b57..e533bf7 100644 > --- a/docs/domain_support.md > +++ b/docs/domain_support.md > @@ -160,8 +160,11 @@ The DT properties of a domain instance DT node are as follows: > * **regions** (Optional) - The list of domain memory region DT node phandle > and access permissions for the domain instance. Each list entry is a pair > of DT node phandle and access permissions. The access permissions are > - represented as a 32bit bitmask having bits: **readable** (BIT[0]), > - **writeable** (BIT[1]), **executable** (BIT[2]), and **m-mode** (BIT[3]). > + represented as a 32bit bitmask having bits: **M readable** (BIT[0]), > + **M writeable** (BIT[1]), **M executable** (BIT[2]), **SU readable** > + (BIT[3]), **SU writable** (BIT[4]), and **SU executable** (BIT[5]). I think you missed documenting BIT[6] which is for enforcing. > + Any region of a domain defined in DT node cannot have only M-bits set > + in access permissions i.e. it cannot be an m-mode only accessible region. > * **boot-hart** (Optional) - The DT node phandle of the HART booting the > domain instance. If coldboot HART is assigned to the domain instance then > this DT property is ignored and the coldboot HART is assumed to be the > -- > 2.39.0 > > > -- > opensbi mailing list > opensbi@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/opensbi Regards, Anup
diff --git a/docs/domain_support.md b/docs/domain_support.md index 8963b57..e533bf7 100644 --- a/docs/domain_support.md +++ b/docs/domain_support.md @@ -160,8 +160,11 @@ The DT properties of a domain instance DT node are as follows: * **regions** (Optional) - The list of domain memory region DT node phandle and access permissions for the domain instance. Each list entry is a pair of DT node phandle and access permissions. The access permissions are - represented as a 32bit bitmask having bits: **readable** (BIT[0]), - **writeable** (BIT[1]), **executable** (BIT[2]), and **m-mode** (BIT[3]). + represented as a 32bit bitmask having bits: **M readable** (BIT[0]), + **M writeable** (BIT[1]), **M executable** (BIT[2]), **SU readable** + (BIT[3]), **SU writable** (BIT[4]), and **SU executable** (BIT[5]). + Any region of a domain defined in DT node cannot have only M-bits set + in access permissions i.e. it cannot be an m-mode only accessible region. * **boot-hart** (Optional) - The DT node phandle of the HART booting the domain instance. If coldboot HART is assigned to the domain instance then this DT property is ignored and the coldboot HART is assumed to be the
Updated the various permissions bits available for domains defined in DT node and restrictions on them. Signed-off-by: Himanshu Chauhan <hchauhan@ventanamicro.com> --- docs/domain_support.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)