From patchwork Wed May 12 11:12:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Schaefer X-Patchwork-Id: 1477542 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=lzhAUrYT; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=y9yJQdVN; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=danielschaefer.me header.i=@danielschaefer.me header.a=rsa-sha256 header.s=mail header.b=fZFykWBE; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FgBwc3XDmz9sRK for ; Wed, 12 May 2021 21:13:04 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=KJUYTAoOmdMtar2BCdv1or0pcPVBssWI1Lxzw+Tv0HM=; b=lzhAUrYTuNHNKRcJ4qL7+gxL0O AGymzNRvIPEZD4GOuhUZhZSKqDxObzdmR4N8yfJAzfZdL9Pp1IEL/g1ISBl1Z2yF5f9qxB257JL7B V/33NeCoQdPNqU1mbN32HTcYlXsZu17Z38Aozuf/LlDmo0G9VyvJTUj9Gp91IpOLa8BoVNDmt6e9Q w8VvHzaB/BGNPjTbPhIY5LIWGwwPtsUrRcfvusnI+ZnFUS32mS+1pEHd13zQQgo8YSW676KIvX1hI 0x8XNPmB3Rb2yM2dOQI6joxIQ6+hp3ZPzhIuG/Lqf58CrEbReJdgDGKzHXZ+OkvygL6/CuJ3aL/zP BGx/pfvw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgmnT-002afV-Ik; Wed, 12 May 2021 11:12:59 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgmnR-002afL-2T for opensbi@desiato.infradead.org; Wed, 12 May 2021 11:12:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=O+Cehk6qu06Bio3ZEklqr5B4Br8c2LzDK1cQCLo978s=; b=y9yJQdVNYztqD5vmuyUiJHiKXC yp9nfTv4cKxVlI2BTklNpRUUQzEjNTAcZNBLRQDLui3Jox7++TrCei9AxTLMwH8tA6tPSm76Nw7Ok s7Pm1ApAOWHRmRUi9FFZz64X/e7NHBw5AJ30vQPOntG4qEJbeWlVIDouVzrN4xhVAiuQDkH02M40U 22lvf7wE0RxGLYSFRMLse579X1QEruBTDd8WTc0WHTuj9hk28DidF5T5S6Tbe2Ivgt2CN75wkD5kR 0AxbZkUZFIYDd6kGxxCd82iCAGIvuR6zG/vDcWFRYSgfSB+YUwSj3xP0nTnkwPPEfLYS4ceCb7ylE 0v2lPHGg==; Received: from mail.danielschaefer.me ([94.130.178.124]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgmnO-00AIyS-CL for opensbi@lists.infradead.org; Wed, 12 May 2021 11:12:55 +0000 From: Daniel Schaefer DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=danielschaefer.me; s=mail; t=1620817972; bh=F1FEqSDle3Bwrfs/hZ2XOQ3kgJTGP7aK6e7XaNf826k=; h=From:To:Cc:Subject:Date; b=fZFykWBEXmeU9i65RRvkgHiRM05gt3h6jLbNQDJS9J2C8Gn5SRxWA/jTuynd/NLni QwaURhtO4kOYixN3Ez+G9Te/p9j+7acSBPe4nQxC04CsoY4Cdp2YFlTBYakIJZwakH Cgmo7LNf/RgpZ9NctY7Ye8nHRwVfQ9c3jHEoXV/s= To: opensbi@lists.infradead.org Cc: Abner Chang , Anup Patel Subject: [PATCH v1 1/1] lib: utils: Include sbi_strings.h directly Date: Wed, 12 May 2021 19:12:47 +0800 Message-Id: <20210512111247.28416-1-git@danielschaefer.me> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210512_041254_590360_33BF361E X-CRM114-Status: UNSURE ( 7.57 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Daniel Schaefer This file uses `sbi_strncpy`, `sbi_strncmp` and `sbi_memset`, which are defined in `sbi_strings.h`. It should already be transitively included via `#include ` but my toolchain doesn't do that for some reason. Perhaps because the functions that refer to them are `static`? Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [94.130.178.124 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Daniel Schaefer This file uses `sbi_strncpy`, `sbi_strncmp` and `sbi_memset`, which are defined in `sbi_strings.h`. It should already be transitively included via `#include ` but my toolchain doesn't do that for some reason. Perhaps because the functions that refer to them are `static`? Anyways, it would be good to directly reference the header here. Cc: Abner Chang Cc: Anup Patel Signed-off-by: Daniel Schaefer --- lib/utils/fdt/fdt_domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/utils/fdt/fdt_domain.c b/lib/utils/fdt/fdt_domain.c index 95c195d65238..b2b5f6196a1a 100644 --- a/lib/utils/fdt/fdt_domain.c +++ b/lib/utils/fdt/fdt_domain.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include