From patchwork Mon Dec 21 04:25:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1418885 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=1U/+oX6w; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=pR9jpq7/; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=bkvqquLF; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Czmcv2Y20z9sVj for ; Mon, 21 Dec 2020 15:26:20 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=9dfQTUrrqK18I1Fqpj7lFR4HgQR4aVn3FMjn1PcmMgo=; b=1U/+oX6w7NKIP7mpxSKhWOHPLl tplKdPtrFrwlpFDHM0AvNgWW8yoZPF3U/KBJJZvndP+KUPdnBjxqHywidIALkmw8nv+g5jXymFirs NJC11ySb5oIeyH7Z+B3AczAs46LNB+TwtKgWTZbNFFbe57046pSnYbaQy4dYzUU+QdMMyVTAKKNOS ZqyzbdDzDZyF/637GHdEEeWaYTSrMP323BdxOGbJU1gwfsvfp67cMPF1JIjWXedlRGKZbx0/7+qir TxP7HrE+TJNTqWydRCcMgtvXgX9xvGBHDc0lhTS/wOYDwjDOPCz536+GbrB+cg2Hf+NcsxKBI5UdJ aDKZu31g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krClw-0001ji-65; Mon, 21 Dec 2020 04:26:12 +0000 Received: from esa5.hgst.iphmx.com ([216.71.153.144]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krClr-0001j1-OE for opensbi@lists.infradead.org; Mon, 21 Dec 2020 04:26:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1608524767; x=1640060767; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=Zjt5LRzWNvKKD43IrEiqjgbbSWt65D62ryIjSKHkJ8g=; b=pR9jpq7/Rz6zdPaVgOfAmqa6ZWrDMZQi2c/G3/DOnuMC4JuhIKII8KsE e/ReMFL9e43NNwumsZgtg1e2pVfpPKoWP0z7cYgwOgsX4sn2NNJt8oLvL xZb6zTYL8a5WiQiiK2gdGGSI8f8CgNNFxrDQXQHLWHGzYh67ne6XQpVmp G1MqtEGPDt9fl4yzxNDnU9UeTMfwJvUzkMIZwRCCtGN7sOzx8lHGMiLf0 CvJQ8VR9mG83Wf4M5R6hR//p68X7Z5rgw49W4xWkl/16EmKkeKFDxsVja 3Ae5Nt0ojEQbB3+2o16fU4NTNZye1IGoln28xQDn+df0MfviO1HdmoCYX w==; IronPort-SDR: AJmW6/AcU40iQgyxEJ8OKcAU7K9Zr4e51OvlYlML+t+K3OwDCmwQuaP+3Edx4xgqwFCf8rvqiR 0D3Qg9wHels6uqHU6/A5dV5weUTRIhfIrvVBw5JDDMuiQC/tzugAxKhC6JSbtt72NA6iOusZPJ M6QzN1S5hhUE1g0gb1gPMS0f9qLqWYdV/b/4nsZBZkkrFtZS7bLHmSvQ4+2rL+Rnu9m//dEGRP 0D9OdwMk0fdciJjQw00sX6UK0L6f8InCqXmp3QUDH8f2xt8ZMEXo0OVmFHMbfrnfSV5KY//G8O EnE= X-IronPort-AV: E=Sophos;i="5.78,436,1599494400"; d="scan'208";a="155668744" Received: from mail-bn8nam11lp2174.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.174]) by ob1.hgst.iphmx.com with ESMTP; 21 Dec 2020 12:25:59 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UqY6MIVEQIi5/W2ICPkVnrsSgvhG4V6nKmSIZb8aq8cM2EJPuaNwkG9eaTL9c8Hp804UrOs/cC1OSxwIqoyCSWbA0fGmFAvBQN2jOMKokZfdHBhtJzTQ1xDn7jXcdVHL84V83TYhbM1bm/qpEe62lPGB1SkxYyMjJCKv9c+7wru+2t5LQmTaKGjL+Asf5heTY7jljZ13Dc9UQb7afTnzgQuemW2N9j7ei8HRbIDxMWUFc82A3pNqd8SXQd8Yj3WOPQJ031wXWsAu2uV8LubVdm9Cgp3lp6DWmZl5qw7jk8gTWgTw6BYlfzJZSpEItcVv2b7t3ozHOfAmt4Ji4AemMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TuC9aNmeOmz+vMypTSI4+HQrHw6fLpR9n/RE5WyNJSg=; b=WYI+kYt71Uwtt2Pnf48GXJfFDmUdTQ4fQSh5aywnByrFHbnTPx+aQsE/LmzXMkpP9xBVwLcmgG7I5Zx/ScT/aWFvAQ+vWtaXjpiPu81TE6hE5ixO5UVArY0swvRgkwjuzUzJXAqvYUA+W6X688TkQARiSdvECb1xcYa+FrFuOaqeR/zw4WYrogAgr9FH/9FhRdLEp3wQU7D25Y2BOrcM/xX8DGrvSYx++Mds1qpCcniFlzyVBfpsi0yyD+SpawtXNQFc9Flt7Q+pPJDdRM5gQ/eaETI9tr1u4rRPN4mkclfWuLTYBuRkO5XqRpHhCBjtXfscT/un0vEKyNzmcBNSNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TuC9aNmeOmz+vMypTSI4+HQrHw6fLpR9n/RE5WyNJSg=; b=bkvqquLF7+uGC8cR0MpjKI/ZxVJbOf92V1pWURGtZlSRkZie53uou5+S6a7dEy76Za5DbM9m0c39KF9iMLdYOASlAAf48HOFmDgu03K3nIFO5daX9o+VGX93O/vGfxbjoKKAT7PIpMxdlnLujkJM9oCrpZ1POA1BOwyPEZQ761I= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM6PR04MB4396.namprd04.prod.outlook.com (2603:10b6:5:9f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.33; Mon, 21 Dec 2020 04:25:58 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::2513:b200:bdc8:b97]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::2513:b200:bdc8:b97%5]) with mapi id 15.20.3654.031; Mon, 21 Dec 2020 04:25:58 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Subject: [PATCH v2] lib: sbi: Fix sign-extension in sbi_misaligned_load_handler() Date: Mon, 21 Dec 2020 09:55:30 +0530 Message-Id: <20201221042530.31523-1-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 X-Originating-IP: [42.109.148.202] X-ClientProxiedBy: MA1PR01CA0164.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:71::34) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (42.109.148.202) by MA1PR01CA0164.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:71::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.29 via Frontend Transport; Mon, 21 Dec 2020 04:25:55 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: e8ac69ab-8baf-485f-b06b-08d8a5688456 X-MS-TrafficTypeDiagnostic: DM6PR04MB4396: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Cy6X//MywxXcCKxVfgCdi44Qc72Jnad14IuCqq6TZEAQIZfKkj3O6TXI50xAn3g448CGZOft44q1lRgCM17ttNr69QgSnSn2zF6yqm+ss3j4FtJT9bY5fcfnw3Q+BKgHoF0CvmUsquLDnOBnsQjDekvOQV0IpZwhTW6x6oIvZmAWDMPucv3Twcn8pevEJ+mjGLrN3ZJ+a6zZy0wdmiiYAz3W2xqSRP6DGz2gop/2suy/DPzEocuSVgEzgCMCcJ3Kf/s6ksf3qAkivV6Y3eo3O98q1zJKBmNixwT/zXeJcobJcPSdFrMgfPiZwYAx9s4UE9kb4l1qRqibeQIpjBUmeOPXiIfnqPE3z2tj9Y1A3VtPR0xsqCToCisdaArWEvR2unTxAjwplIS4Orrmj3uZMQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(2616005)(52116002)(66946007)(1006002)(110136005)(26005)(6636002)(186003)(7696005)(8886007)(316002)(478600001)(16526019)(1076003)(36756003)(956004)(5660300002)(83380400001)(8676002)(4326008)(8936002)(44832011)(55016002)(6666004)(54906003)(2906002)(86362001)(66556008)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: 5lmUbVmGPSYeO5t9oulFrvBL/WPKwjemtSq83zhIFzEQgOHfZYbMepg9D5d1WbdwKwrKUUSNqso4WzrNxuXiU0/mrX8q9r8MVCkrTQJLQcD/O64BU/eR2xMbPCkLgX/OKb0B5Z3axOS8kLnNB/tE0cYmAujKJIKeG80KgtYR3nKjeMmJUE4B7mqIlbftCgsk8dtCvF/YAjnRgmMrYI8LuaSlm80yRW4bQI8UFrX6UVZJctf28ZROg5zlReoy8e43lVcIMfnGlZkjfdYPMzCuv+n2h12eGuvHKlbMc07qGhzeRscnwSolIeE/LSvdSzFyvD6gXmixBDkkIBMijZq31gdN95UZO8CgQQtbeCetf2oASiVWsBmCAaAw3eZQhrgwNw/5jP2jTzT2U8Erz5Rqm7AP2DdZZLZ0WLGySXYfOIoE6PyMs6bYUPDV3tdUxiMlHNeIFHvBf5xHFPVceRSnU3iP41DV9MEjfUVdeb1cNdSnJf97WxTQqhqMx82DSHq58360iMBXBQbBqIkBqF73IEMyCMWl3/YW64dcnoB69MU+iW3K0LAfibzxrl1zpJHiA+VYoKMrKM0k0pLWk6VsaOZYQPrT0IkNmrxX+gRZ5CaF7jQOv5G4exOc2S2f3uF6U2jJsX3HG/TL8VjopuL8mXuM8rnQMUSAGdMHxWU8NrYpcijRF5LmeyNVu/gB8SIz6HRkgmSlrqcxnkr4VARCzvFX7MUIyT9w72hw5UxiQgqF4r3r+ewsbeNug7H9Cikcl4UMpP3MEKmYpXWqfqOWPirDeXX9PLGpOvvftypOflMLULP+6YfSu4bD6eAqKTPTE1YsyBLganP1YKXuG/MSbzI4CvsirTgN/kHpFLOxxEres7l2uZYX/gLgD69ih95b4ybFnl/kKZsepaQC67v3DHoMzmpL2s5C0nfBulbMwjwWJiJNTq+Xa1X2t/0pcghQYTg7YjzVk/5Qlt5c18h6yAnyWePkjzd4eBKDCkWBjqkoriZhvD5DHQ7nyQs4asP7 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2020 04:25:58.7251 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-Network-Message-Id: e8ac69ab-8baf-485f-b06b-08d8a5688456 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U07FmCxsIapOl+m0nM9JUx4+rbYxd8dUV8UGzYyk/Pog/wlSuZFqhlvaSjUwx4WRifo4P0jjb0BkJq+2UGy/+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB4396 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201220_232608_108791_C44B96CA X-CRM114-Status: GOOD ( 15.65 ) X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [216.71.153.144 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , Anup Patel , opensbi@lists.infradead.org Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The misaligned load emulation does not sign-extend values correctly due to missing sign typecast in value passed to the SET_RD() macro. A very easy way to reproduce this issue is to load 16-bit value 0xff1e from a byte aligned address using LH instruction on hardware lacking misaligned load/store. This patch fixes sbi_misaligned_load_handler() for above issue. Signed-off-by: Anup Patel Reviewed-by: Atish Patra --- Changes since v1: - Cast after left-shift and use braces. --- lib/sbi/sbi_misaligned_ldst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sbi/sbi_misaligned_ldst.c b/lib/sbi/sbi_misaligned_ldst.c index 964a372..5057cb5 100644 --- a/lib/sbi/sbi_misaligned_ldst.c +++ b/lib/sbi/sbi_misaligned_ldst.c @@ -128,7 +128,7 @@ int sbi_misaligned_load_handler(ulong addr, ulong tval2, ulong tinst, } if (!fp) - SET_RD(insn, regs, val.data_ulong << shift >> shift); + SET_RD(insn, regs, ((long)(val.data_ulong << shift)) >> shift); #ifdef __riscv_flen else if (len == 8) SET_F64_RD(insn, regs, val.data_u64);