| Message ID | 20201121094756.4154728-6-anup.patel@wdc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | OpenSBI domain configuration using device tree | expand |
On Sat, 2020-11-21 at 15:17 +0530, Anup Patel wrote: > We should use lower bits for domain memory region access permissions > and higher bits for other domain memory region attributes. This helps > us use same bit assignment for parsing domain memory region access > permissions from device tree. > > Signed-off-by: Anup Patel <anup.patel@wdc.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > include/sbi/sbi_domain.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/include/sbi/sbi_domain.h b/include/sbi/sbi_domain.h > index 6f90b26..a7cb61e 100644 > --- a/include/sbi/sbi_domain.h > +++ b/include/sbi/sbi_domain.h > @@ -39,8 +39,10 @@ struct sbi_domain_memregion { > #define SBI_DOMAIN_MEMREGION_READABLE (1UL << 0) > #define SBI_DOMAIN_MEMREGION_WRITEABLE (1UL << 1) > #define SBI_DOMAIN_MEMREGION_EXECUTABLE (1UL << 2) > -#define SBI_DOMAIN_MEMREGION_MMIO (1UL << 3) > -#define SBI_DOMAIN_MEMREGION_MMODE (1UL << 4) > +#define SBI_DOMAIN_MEMREGION_MMODE (1UL << 3) > +#define SBI_DOMAIN_MEMREGION_ACCESS_MASK (0xfUL) > + > +#define SBI_DOMAIN_MEMREGION_MMIO (1UL << 31) > unsigned long flags; > }; >
On Sat, Nov 21, 2020 at 2:53 PM Anup Patel <anup.patel@wdc.com> wrote: > > We should use lower bits for domain memory region access permissions > and higher bits for other domain memory region attributes. This helps > us use same bit assignment for parsing domain memory region access > permissions from device tree. > > Signed-off-by: Anup Patel <anup.patel@wdc.com> > --- > include/sbi/sbi_domain.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/include/sbi/sbi_domain.h b/include/sbi/sbi_domain.h > index 6f90b26..a7cb61e 100644 > --- a/include/sbi/sbi_domain.h > +++ b/include/sbi/sbi_domain.h > @@ -39,8 +39,10 @@ struct sbi_domain_memregion { > #define SBI_DOMAIN_MEMREGION_READABLE (1UL << 0) > #define SBI_DOMAIN_MEMREGION_WRITEABLE (1UL << 1) > #define SBI_DOMAIN_MEMREGION_EXECUTABLE (1UL << 2) > -#define SBI_DOMAIN_MEMREGION_MMIO (1UL << 3) > -#define SBI_DOMAIN_MEMREGION_MMODE (1UL << 4) > +#define SBI_DOMAIN_MEMREGION_MMODE (1UL << 3) > +#define SBI_DOMAIN_MEMREGION_ACCESS_MASK (0xfUL) > + > +#define SBI_DOMAIN_MEMREGION_MMIO (1UL << 31) > unsigned long flags; > }; > > -- > 2.25.1 > > > -- > opensbi mailing list > opensbi@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/opensbi Reviewed-by: Atish Patra <atish.patra@wdc.com>
diff --git a/include/sbi/sbi_domain.h b/include/sbi/sbi_domain.h index 6f90b26..a7cb61e 100644 --- a/include/sbi/sbi_domain.h +++ b/include/sbi/sbi_domain.h @@ -39,8 +39,10 @@ struct sbi_domain_memregion { #define SBI_DOMAIN_MEMREGION_READABLE (1UL << 0) #define SBI_DOMAIN_MEMREGION_WRITEABLE (1UL << 1) #define SBI_DOMAIN_MEMREGION_EXECUTABLE (1UL << 2) -#define SBI_DOMAIN_MEMREGION_MMIO (1UL << 3) -#define SBI_DOMAIN_MEMREGION_MMODE (1UL << 4) +#define SBI_DOMAIN_MEMREGION_MMODE (1UL << 3) +#define SBI_DOMAIN_MEMREGION_ACCESS_MASK (0xfUL) + +#define SBI_DOMAIN_MEMREGION_MMIO (1UL << 31) unsigned long flags; };
We should use lower bits for domain memory region access permissions and higher bits for other domain memory region attributes. This helps us use same bit assignment for parsing domain memory region access permissions from device tree. Signed-off-by: Anup Patel <anup.patel@wdc.com> --- include/sbi/sbi_domain.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)