[00/12] OpenSBI Hart Index Optimizations

Message ID	20240830154929.3971790-1-samuel.holland@sifive.com
Headers	show Return-Path: <opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> From: Samuel Holland <samuel.holland@sifive.com> To: opensbi@lists.infradead.org Subject: [PATCH 00/12] OpenSBI Hart Index Optimizations Date: Fri, 30 Aug 2024 08:49:04 -0700 Message-ID: <20240830154929.3971790-1-samuel.holland@sifive.com> MIME-Version: 1.0 preview: This series converts more of OpenSBI to use hart indexes instead of hartids, which minimizes the number of calls to the somewhat expensive sbi_hartid_to_hartindex() function. This reduces both static [...] Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:429 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 T_SCC_BODY_TEXT_LINE No description available. Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "opensbi" <opensbi-bounces@lists.infradead.org> Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org
Series	OpenSBI Hart Index Optimizations \| expand [00/12] OpenSBI Hart Index Optimizations [01/12] lib: sbi_init: Remove obsolete hartid check [02/12] include: sbi: Store the hart index in struct sbi_scratch [03/12] lib: sbi: Use current_hartindex() where possible [04/12] lib: sbi_sse: Cache the event's target hart index [05/12] lib: utils/irqchip: Look up IMSIC data by hart index [06/12] lib: sbi_ecall_legacy: Use SBI v0.2 encoding for "all harts" [07/12] lib: sbi: Simplify halt broadcast logic [08/12] lib: sbi: Update __sbi_hsm_hart_get_state() to take a hart index [09/12] lib: sbi: Use sbi_hartmask in sbi_hsm_hart_interruptible_mask() [10/12] lib: sbi: Update sbi_domain_is_assigned_hart() to take a hart index [11/12] lib: sbi: Update sbi_{entry,init}_count() to take a hart index [12/12] lib: sbi: Remove unused hartid parameters

Message ID

20240830154929.3971790-1-samuel.holland@sifive.com

Headers

From: Samuel Holland <samuel.holland@sifive.com>
To: opensbi@lists.infradead.org
Subject: [PATCH 00/12] OpenSBI Hart Index Optimizations
Date: Fri, 30 Aug 2024 08:49:04 -0700
Message-ID: <20240830154929.3971790-1-samuel.holland@sifive.com>
MIME-Version: 1.0
Precedence: list
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "opensbi" <opensbi-bounces@lists.infradead.org>
Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org

Series

OpenSBI Hart Index Optimizations | expand

Message

Samuel Holland Aug. 30, 2024, 3:49 p.m. UTC

This series converts more of OpenSBI to use hart indexes instead of
hartids, which minimizes the number of calls to the somewhat expensive
sbi_hartid_to_hartindex() function. This reduces both static code size
(728 bytes for a generic firmware with GCC 13.3) and the dynamic number
of hart index lookups. A quick test in QEMU shows 98% fewer calls to
sbi_hartid_to_hartindex() during the Linux kernel boot process. (Tested
by printing the number of calls in sbi_system_reset() and booting Linux
with the command line "rdinit=/bin/busybox -- reboot -f". Calls reduced
from about 39000 to about 800.)


Samuel Holland (12):
  lib: sbi_init: Remove obsolete hartid check
  include: sbi: Store the hart index in struct sbi_scratch
  lib: sbi: Use current_hartindex() where possible
  lib: sbi_sse: Cache the event's target hart index
  lib: utils/irqchip: Look up IMSIC data by hart index
  lib: sbi_ecall_legacy: Use SBI v0.2 encoding for "all harts"
  lib: sbi: Simplify halt broadcast logic
  lib: sbi: Update __sbi_hsm_hart_get_state() to take a hart index
  lib: sbi: Use sbi_hartmask in sbi_hsm_hart_interruptible_mask()
  lib: sbi: Update sbi_domain_is_assigned_hart() to take a hart index
  lib: sbi: Update sbi_{entry,init}_count() to take a hart index
  lib: sbi: Remove unused hartid parameters

 firmware/fw_base.S                |  2 +
 include/sbi/sbi_domain.h          | 17 ++++----
 include/sbi/sbi_domain_context.h  |  7 ++--
 include/sbi/sbi_hsm.h             |  7 ++--
 include/sbi/sbi_init.h            |  4 +-
 include/sbi/sbi_scratch.h         | 10 ++++-
 include/sbi_utils/irqchip/imsic.h |  4 +-
 lib/sbi/sbi_dbtr.c                |  3 +-
 lib/sbi/sbi_domain.c              | 19 +++++----
 lib/sbi/sbi_domain_context.c      |  6 +--
 lib/sbi/sbi_ecall_legacy.c        | 25 ++++++------
 lib/sbi/sbi_hsm.c                 | 64 +++++++++++++++----------------
 lib/sbi/sbi_init.c                | 30 +++++----------
 lib/sbi/sbi_ipi.c                 | 44 +++++++++++----------
 lib/sbi/sbi_sse.c                 | 10 +++--
 lib/sbi/sbi_system.c              | 20 +++-------
 lib/utils/fdt/fdt_fixup.c         |  5 ++-
 lib/utils/irqchip/imsic.c         | 10 ++---
 platform/generic/andes/ae350.c    |  6 ++-
 19 files changed, 143 insertions(+), 150 deletions(-)