=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte




--
Regards,
Alexander Chemeris.
CEO, Fairwaves, Inc.
https://fairwaves.co


------------------------------

Message: 2
Date: Thu, 26 Jan 2017 14:22:47 -0500 (EST)
From: David Miller <davem@davemloft.net<mailto:davem@davemloft.net>>
To: aschultz@tpip.net<mailto:aschultz@tpip.net>
Cc: pablo@netfilter.org<mailto:pablo@netfilter.org>, netdev@vger.kernel.org<mailto:netdev@vger.kernel.org>,
   Lionel.Gauthier@eurecom.fr<mailto:Lionel.Gauthier@eurecom.fr>, openbsc@lists.osmocom.org<mailto:openbsc@lists.osmocom.org>,
   laforge@gnumonks.org<mailto:laforge@gnumonks.org>
Subject: Re: [PATCH net v2 3/3] gtp: fix cross netns recv on gtp
   socket
Message-ID: <20170126.142247.527598780818100974.davem@davemloft.net<mailto:20170126.142247.527598780818100974.davem@davemloft.net>>
Content-Type: Text/Plain; charset=iso-8859-7

From: Andreas Schultz <aschultz@tpip.net<mailto:aschultz@tpip.net>>
Date: Thu, 26 Jan 2017 16:11:34 +0100

The use of the passed through netlink src_net to check for a
cross netns operation was wrong. Using the GTP socket and the
GTP netdevice is always correct (even if the netdev has been
moved to new netns after link creation).

Remove the now obsolete net field from gtp_dev.

Signed-off-by: Andreas Schultz <aschultz@tpip.net<mailto:aschultz@tpip.net>>

Please at least compile test your submissions:

drivers/net/gtp.c: In function ?gtp_newlink?:
drivers/net/gtp.c:677:8: error: too many arguments to function ?gtp_encap_enable?
 err = gtp_encap_enable(dev, gtp, fd0, fd1, src_net);
       ^
drivers/net/gtp.c:659:12: note: declared here
static int gtp_encap_enable(struct net_device *dev, struct gtp_dev *gtp,
           ^
drivers/net/gtp.c: At top level:
drivers/net/gtp.c:822:12: error: conflicting types for ?gtp_encap_enable?
static int gtp_encap_enable(struct net_device *dev, struct gtp_dev *gtp,
           ^
drivers/net/gtp.c:659:12: note: previous declaration of ?gtp_encap_enable? was here
static int gtp_encap_enable(struct net_device *dev, struct gtp_dev *gtp,
           ^
drivers/net/gtp.c:659:12: warning: ?gtp_encap_enable? used but never defined
drivers/net/gtp.c:822:12: warning: ?gtp_encap_enable? defined but not used [-Wunused-function]
static int gtp_encap_enable(struct net_device *dev, struct gtp_dev *gtp,
           ^
scripts/Makefile.build:299: recipe for target 'drivers/net/gtp.o' failed

------------------------------

Message: 3
Date: Thu, 26 Jan 2017 21:40:27 +0100
From: Neels Hofmeyr <nhofmeyr@sysmocom.de<mailto:nhofmeyr@sysmocom.de>>
To: Alexander Chemeris <alexander.chemeris@gmail.com<mailto:alexander.chemeris@gmail.com>>
Cc: Max <msuraev@sysmocom.de<mailto:msuraev@sysmocom.de>>, OpenBSC Mailing List
   <openbsc@lists.osmocom.org<mailto:openbsc@lists.osmocom.org>>
Subject: Re: [MERGED] osmo-trx[master]: Do not embed sqlite3 when
   building
Message-ID: <20170126204027.GA7681@my.box<mailto:20170126204027.GA7681@my.box>>
Content-Type: text/plain; charset="us-ascii"

On Thu, Jan 26, 2017 at 08:53:07PM +0400, Alexander Chemeris wrote:
Great. I was also going to ask about debian contrl files, etc. Glad
this is already fixed.

Is there a way to subscribe to gerrit patches for a particular project?

I'm not sure, but I guess not. We have our gerrit-log mailing list that catches
all changes https://lists.osmocom.org/mailman/listinfo/gerrit-log -- otherwise
take a look at your user's settings, maybe there's such a feature hidden there?

~N

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20170126/5e2767bd/attachment-0001.bin>

------------------------------

Message: 4
Date: Fri, 27 Jan 2017 03:36:14 +0100
From: Neels Hofmeyr <nhofmeyr@sysmocom.de<mailto:nhofmeyr@sysmocom.de>>
To: openbsc@lists.osmocom.org<mailto:openbsc@lists.osmocom.org>
Subject: HEADS UP: jenkins DOWN
Message-ID: <20170127023614.GA13650@my.box<mailto:20170127023614.GA13650@my.box>>
Content-Type: text/plain; charset="iso-8859-1"

While I was waiting for jenkins just now, I noticed that it was getting
impossibly slow despite an idle CPU. An attempt to restart resulted in failure
to launch jenkins due to "Disk quota exceeded".

There are things happening that I don't understand (file system is shrinking as
I remove files). I need help from Holger (or Harald?), to understand and
probably fix with a simple command making more space for the jail...

Until then our jenkins will be DOWN :/

~N

--
- Neels Hofmeyr <nhofmeyr@sysmocom.de<mailto:nhofmeyr@sysmocom.de>>          http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Gesch?ftsf?hrer / Managing Directors: Harald Welte
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20170127/9240154b/attachment-0001.bin>

------------------------------

Message: 5
Date: Fri, 27 Jan 2017 03:57:59 +0100
From: Neels Hofmeyr <nhofmeyr@sysmocom.de<mailto:nhofmeyr@sysmocom.de>>
To: openbsc@lists.osmocom.org<mailto:openbsc@lists.osmocom.org>
Subject: HEADS DOWN: jenkins UP
Message-ID: <20170127025759.GB13650@my.box<mailto:20170127025759.GB13650@my.box>>
Content-Type: text/plain; charset="iso-8859-1"

Just after I gave up and sent the mail, I found the point: we have three daily
and three weekly backup snapshots taken of the jenkins jail, which *shares*
disk quota with the actively used file system. Removing files doesn't remove
them from the snapshots, so the only way short of discarding snapshots (?) is
to increase the overall quota. I set it from 40G up to 60G, and sure enough
jenkins runs again.

We should probably set a refquota so that the live file system's quota is
somewhat independent from the quota used for snapshots. I'll not do this before
consulting with the experts though.

~N



On Fri, Jan 27, 2017 at 03:36:14AM +0100, Neels Hofmeyr wrote:
While I was waiting for jenkins just now, I noticed that it was getting
impossibly slow despite an idle CPU. An attempt to restart resulted in failure
to launch jenkins due to "Disk quota exceeded".

There are things happening that I don't understand (file system is shrinking as
I remove files). I need help from Holger (or Harald?), to understand and
probably fix with a simple command making more space for the jail...

Until then our jenkins will be DOWN :/

~N

--
- Neels Hofmeyr <nhofmeyr@sysmocom.de<mailto:nhofmeyr@sysmocom.de>>          http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Gesch?ftsf?hrer / Managing Directors: Harald Welte
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20170127/76c52d36/attachment-0001.bin>

------------------------------

Message: 6
Date: Fri, 27 Jan 2017 09:13:09 +0100
From: Holger Freyther <holger@freyther.de<mailto:holger@freyther.de>>
To: Neels Hofmeyr <nhofmeyr@sysmocom.de<mailto:nhofmeyr@sysmocom.de>>
Cc: openbsc@lists.osmocom.org<mailto:openbsc@lists.osmocom.org>
Subject: Re: HEADS DOWN: jenkins UP
Message-ID: <B4CAC9D5-AD49-46B6-8806-C8B0AFCF28FF@freyther.de<mailto:B4CAC9D5-AD49-46B6-8806-C8B0AFCF28FF@freyther.de>>
Content-Type: text/plain; charset=us-ascii


On 27 Jan 2017, at 03:57, Neels Hofmeyr <nhofmeyr@sysmocom.de<mailto:nhofmeyr@sysmocom.de>> wrote:

Just after I gave up and sent the mail, I found the point: we have three daily
and three weekly backup snapshots taken of the jenkins jail, which *shares*
disk quota with the actively used file system. Removing files doesn't remove
them from the snapshots, so the only way short of discarding snapshots (?) is
to increase the overall quota. I set it from 40G up to 60G, and sure enough
jenkins runs again.



We should probably set a refquota so that the live file system's quota is
somewhat independent from the quota used for snapshots. I'll not do this before
consulting with the experts though.

good analysis. Not using refquota is a historic mistake. I have changed that
for the jenkins.osmocom.org<http://jenkins.osmocom.org> jail.

holger



------------------------------

Message: 7
Date: Fri, 27 Jan 2017 10:40:55 +0100
From: Andreas Schultz <aschultz@tpip.net<mailto:aschultz@tpip.net>>
To: Pablo Neira <pablo@netfilter.org<mailto:pablo@netfilter.org>>
Cc: netdev@vger.kernel.org<mailto:netdev@vger.kernel.org>, Lionel Gauthier
   <Lionel.Gauthier@eurecom.fr<mailto:Lionel.Gauthier@eurecom.fr>>, openbsc@lists.osmocom.org<mailto:openbsc@lists.osmocom.org>, Harald Welte
   <laforge@gnumonks.org<mailto:laforge@gnumonks.org>>, SF Markus Elfring
   <elfring@users.sourceforge.net<mailto:elfring@users.sourceforge.net>>
Subject: [PATCH net v3 0/3] various gtp fixes
Message-ID: <20170127094058.7899-1-aschultz@tpip.net<mailto:20170127094058.7899-1-aschultz@tpip.net>>

I'm sorry for the compile error mess up in the last version.
It's no excuse for not test compiling, but the hunks got lost in
a rebase.

This is the part of the previous "simple gtp improvements" series
that Pablo indicated should go into net.

The addition of the module alias fixes genl family autoloading,
clearing the DF bit fixes a protocol violation in regard to the
specification and the netns comparison fixes a corner case of
cross netns recv.

Andreas

v2->v3: fix compiler error introduced in rebase

--
Andreas Schultz (3):
 gtp: add genl family modules alias
 gtp: clear DF bit on GTP packet tx
 gtp: fix cross netns recv on gtp socket

drivers/net/gtp.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)

--
2.10.2



------------------------------

Message: 8
Date: Fri, 27 Jan 2017 10:40:57 +0100
From: Andreas Schultz <aschultz@tpip.net<mailto:aschultz@tpip.net>>
To: Pablo Neira <pablo@netfilter.org<mailto:pablo@netfilter.org>>
Cc: netdev@vger.kernel.org<mailto:netdev@vger.kernel.org>, Lionel Gauthier
   <Lionel.Gauthier@eurecom.fr<mailto:Lionel.Gauthier@eurecom.fr>>, openbsc@lists.osmocom.org<mailto:openbsc@lists.osmocom.org>, Harald Welte
   <laforge@gnumonks.org<mailto:laforge@gnumonks.org>>, SF Markus Elfring
   <elfring@users.sourceforge.net<mailto:elfring@users.sourceforge.net>>
Subject: [PATCH net v3 2/3] gtp: clear DF bit on GTP packet tx
Message-ID: <20170127094058.7899-3-aschultz@tpip.net<mailto:20170127094058.7899-3-aschultz@tpip.net>>

3GPP TS 29.281 and 3GPP TS 29.060 imply that GTP-U packets should be
sent with the DF bit cleared. For example 3GPP TS 29.060, Release 8,
Section 13.2.2:

Backbone router: Any router in the backbone may fragment the GTP
packet if needed, according to IPv4.

Signed-off-by: Andreas Schultz <aschultz@tpip.net<mailto:aschultz@tpip.net>>
Acked-by: Harald Welte <laforge@netfilter.org<mailto:laforge@netfilter.org>>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org<mailto:pablo@netfilter.org>>
---
drivers/net/gtp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index 7580ccc..1df54d6 100644
--- a/drivers/net/gtp.c
+++ b/drivers/net/gtp.c
@@ -612,7 +612,7 @@ static netdev_tx_t gtp_dev_xmit(struct sk_buff *skb, struct net_device *dev)
                   pktinfo.fl4.saddr, pktinfo.fl4.daddr,
                   pktinfo.iph->tos,
                   ip4_dst_hoplimit(&pktinfo.rt->dst),
-                    htons(IP_DF),
+                    0,
                   pktinfo.gtph_port, pktinfo.gtph_port,
                   true, false);
       break;
