| Message ID | CABmJbFV5xNHmxQ1YZSXs1+ig5Bag15kidcTSjBDofH5agR_2fQ@mail.gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Hi Holger, It seems there are no more comments on this code. Could you please merge it? It is independent of other changes. On Thu, Mar 13, 2014 at 12:18 PM, Alexander Chemeris <alexander.chemeris@gmail.com> wrote: > On Thu, Mar 13, 2014 at 12:44 AM, Holger Hans Peter Freyther > <holger@freyther.de> wrote: >> On Wed, Mar 12, 2014 at 08:49:52PM +0400, Alexander Chemeris wrote: >> >>> +#include <osmocom/core/logging.h> >>> +#include <include/osmocom/core/application.h> >> >> include/osmocom/core?? > > Hum, indeed. I have to update my mind model on what leads to compile > errors and what is not. > > An updated patch is attached. Please merge it if there are no more comments. > > -- > Regards, > Alexander Chemeris. > CEO, Fairwaves, Inc. / ООО УмРадио > https://fairwaves.co
From a1c751971504bd51bfd7f185b59bde1c3b77ea95 Mon Sep 17 00:00:00 2001 From: Alexander Chemeris <Alexander.Chemeris@gmail.com> Date: Fri, 7 Mar 2014 20:42:03 +0100 Subject: [PATCH 2/6] sms_test: Do not crash on logging. --- tests/sms/sms_test.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/sms/sms_test.c b/tests/sms/sms_test.c index 755b321..30ce1f4 100644 --- a/tests/sms/sms_test.c +++ b/tests/sms/sms_test.c @@ -31,6 +31,11 @@ #include <osmocom/core/msgb.h> #include <osmocom/core/utils.h> +#include <osmocom/core/logging.h> +#include <osmocom/core/application.h> + +struct log_info fake_log_info = {}; + struct test_case { const uint8_t *input; const uint16_t input_length; @@ -278,6 +283,9 @@ int main(int argc, char** argv) int nchars; char result[256]; + /* Fake logging. */ + osmo_init_logging(&fake_log_info); + /* test 7-bit encoding */ for (i = 0; i < ARRAY_SIZE(test_encode); ++i) { /* Test legacy function (return value only) */ -- 1.7.9.5