| Message ID | 1461328898-8298-2-git-send-email-sergey.kostanbaev@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
Just minor remarks... IMHO it would be good to mention in the commit log the file/function in which the constant will be used, if not adding the constant along with its first use. Why are you adding the GPRS_GSUP_MSGT_USSD_MAP out of sequence? So far the constants are sorted by bit value, rather comply to that. ~Neels On Fri, Apr 22, 2016 at 02:41:31PM +0200, Sergey Kostanbaev wrote: > From: Sergey Kostanbaev <Sergey.Kostanbaev@fairwaves.co> > > --- > openbsc/include/openbsc/gprs_gsup_messages.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/openbsc/include/openbsc/gprs_gsup_messages.h b/openbsc/include/openbsc/gprs_gsup_messages.h > index 8cbc809..fb9c66e 100644 > --- a/openbsc/include/openbsc/gprs_gsup_messages.h > +++ b/openbsc/include/openbsc/gprs_gsup_messages.h > @@ -53,6 +53,8 @@ enum gprs_gsup_iei { > }; > > enum gprs_gsup_message_type { > + GPRS_GSUP_MSGT_USSD_MAP = 0b01111111, > + > GPRS_GSUP_MSGT_UPDATE_LOCATION_REQUEST = 0b00000100, > GPRS_GSUP_MSGT_UPDATE_LOCATION_ERROR = 0b00000101, > GPRS_GSUP_MSGT_UPDATE_LOCATION_RESULT = 0b00000110, > -- > 1.9.1 >
diff --git a/openbsc/include/openbsc/gprs_gsup_messages.h b/openbsc/include/openbsc/gprs_gsup_messages.h index 8cbc809..fb9c66e 100644 --- a/openbsc/include/openbsc/gprs_gsup_messages.h +++ b/openbsc/include/openbsc/gprs_gsup_messages.h @@ -53,6 +53,8 @@ enum gprs_gsup_iei { }; enum gprs_gsup_message_type { + GPRS_GSUP_MSGT_USSD_MAP = 0b01111111, + GPRS_GSUP_MSGT_UPDATE_LOCATION_REQUEST = 0b00000100, GPRS_GSUP_MSGT_UPDATE_LOCATION_ERROR = 0b00000101, GPRS_GSUP_MSGT_UPDATE_LOCATION_RESULT = 0b00000110,
From: Sergey Kostanbaev <Sergey.Kostanbaev@fairwaves.co> --- openbsc/include/openbsc/gprs_gsup_messages.h | 2 ++ 1 file changed, 2 insertions(+)