diff mbox

[2/3] ipaccess_rcvmsg: fix returncode, add partial write warning

Message ID 1456341367-15394-3-git-send-email-nhofmeyr@sysmocom.de
State Accepted
Headers show

Commit Message

Neels Hofmeyr Feb. 24, 2016, 7:16 p.m. UTC 
Kills a compiler warning.
---
 openbsc/src/ipaccess/ipaccess-proxy.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
diff mbox

Patch

diff --git a/openbsc/src/ipaccess/ipaccess-proxy.c b/openbsc/src/ipaccess/ipaccess-proxy.c
index ab43b9e..3dfaeca 100644
--- a/openbsc/src/ipaccess/ipaccess-proxy.c
+++ b/openbsc/src/ipaccess/ipaccess-proxy.c
@@ -527,6 +527,12 @@  static int ipaccess_rcvmsg(struct ipa_proxy_conn *ipc, struct msgb *msg,
 			return -EIO;
 		}
 		ret = write(bfd->fd, ipbc->id_resp, ipbc->id_resp_len);
+		if (ret != ipbc->id_resp_len) {
+			LOGP(DLINP, LOGL_ERROR, "Partial write: %d of %d\n",
+			     ret, ipbc->id_resp_len);
+			ret = -EIO;
+		}
+		else ret = 0;
 		break;
 	case IPAC_MSGT_ID_ACK:
 		DEBUGP(DLMI, "ID_ACK? -> ACK!\n");
@@ -537,7 +543,7 @@  static int ipaccess_rcvmsg(struct ipa_proxy_conn *ipc, struct msgb *msg,
 		return 1;
 		break;
 	}
-	return 0;
+	return ret;
 }
 
 struct msgb *ipaccess_proxy_read_msg(struct osmo_fd *bfd, int *error)