| Message ID | 20240930214659.193376-1-william@wkennington.com |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts nuvoton: Add EDAC node | expand |
Hi William, As a bit of a nit, you missed the `:` after `dts` in the patch subject. On Mon, 2024-09-30 at 14:46 -0700, William A. Kennington III wrote: > From: "William A. Kennington III" <wak@google.com> > > We have the driver support code, now we just need to expose the device > node which can export the EDAC properties for the system memory > controller. Tested on real hardware to verify that error counters show > up. > > Signed-off-by: William A. Kennington III <wak@google.com> > --- > arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi > index 5aeb5009a5d7..019abceb16a0 100644 > --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi > +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi > @@ -127,6 +127,13 @@ clk: clock-controller@f0801000 { > clocks = <&clk_refclk>, <&clk_sysbypck>, <&clk_mcbypck>; > }; > > + mc: memory-controller@f0824000 { > + compatible = "nuvoton,"; This compatible string doesn't look right to me. Are you sure? Andrew
diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi index 5aeb5009a5d7..019abceb16a0 100644 --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi @@ -127,6 +127,13 @@ clk: clock-controller@f0801000 { clocks = <&clk_refclk>, <&clk_sysbypck>, <&clk_mcbypck>; }; + mc: memory-controller@f0824000 { + compatible = "nuvoton,"; + reg = <0xf0824000 0x1000>; + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + gmac0: eth@f0802000 { device_type = "network"; compatible = "snps,dwmac";