diff mbox series

[v5,1/2] dt-bindings: arm: aspeed: Add aspeed,video binding

Message ID 20240819080859.1304671-2-jammy_huang@aspeedtech.com
State New
Headers show
Series media: aspeed: Allow to capture from SoC display (GFX) | expand

Commit Message

Jammy Huang Aug. 19, 2024, 8:08 a.m. UTC
The Video Engine block in ASPEED Silicon SoCs is responsible for video
compressions with a wide range of video quality and compression
ratio options. It can capture and compress video data from digital or
analog sources.

Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
---
 .../bindings/arm/aspeed/aspeed,video.yaml     | 81 +++++++++++++++++++
 1 file changed, 81 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/aspeed/aspeed,video.yaml

Comments

Krzysztof Kozlowski Aug. 19, 2024, 8:24 a.m. UTC | #1
On Mon, Aug 19, 2024 at 04:08:58PM +0800, Jammy Huang wrote:
> The Video Engine block in ASPEED Silicon SoCs is responsible for video
> compressions with a wide range of video quality and compression
> ratio options. It can capture and compress video data from digital or
> analog sources.
> 
> Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
> ---
>  .../bindings/arm/aspeed/aspeed,video.yaml     | 81 +++++++++++++++++++

Why are you adding duplicated binding? Please read the first comments -
you need to first convert TXT to DT schema. Then you add new properties
in a new patch.

>  1 file changed, 81 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/aspeed/aspeed,video.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed,video.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed,video.yaml
> new file mode 100644
> index 000000000000..bef7bd2f310a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed,video.yaml

Filename matching compatible.

> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/aspeed/aspeed,video.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ASPEED Video Engine

ASPEED or Aspeed?

> +
> +maintainers:
> +  - Eddie James <eajames@linux.ibm.com>
> +  - Jammy Huang <jammy_huang@aspeedtech.com>
> +
> +description: |

Drop |

> +  The ASPEED video engine can be configured to capture and compress video
> +  data from digital or analog sources.
> +
> +select:
> +  properties:
> +    compatible:
> +      pattern: "^aspeed,ast[0-9]+-video-engine$"
> +  required:
> +    - compatible

Drop entire select. No clue what is this.

> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - description: Preferred naming style for compatibles of video components
> +        pattern: "^aspeed,ast[0-9]+-video-engine$"

???

No, drop.

> +
> +      - enum:
> +          - aspeed,ast2400-video-engine
> +          - aspeed,ast2500-video-engine
> +          - aspeed,ast2600-video-engine
> +
> +  reg:
> +    minItems: 1

No, maxItems.

> +
> +  clocks:
> +    minItems: 2

No. maxItems.

> +
> +  clock-names:
> +    items:
> +      - const: vclk
> +      - const: eclk
> +
> +  interrupts:
> +    minItems: 1

maxItems

> +
> +  aspeed,scu:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: |
> +      Specifies the scu node that is needed if video wants to capture
> +      from sources other than Host VGA.
> +
> +  aspeed,gfx:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: |
> +      Specifies the Soc Display(gfx) node that needs to be queried to get
> +      related information if video wants to use gfx as capture source.
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - interrupts
> +
> +additionalProperties: true

NAK, this cannot be true. Where do you see any device binding having it
true?


> +
> +examples:
> +  - |
> +    video: video@1e700000 {

Drop unused label

> +          	compatible = "aspeed,ast2600-video-engine";

Fix indentation, this is supposed 4 spaces.
Jammy Huang Aug. 23, 2024, 1:11 a.m. UTC | #2
Hi Krzysztof,

Thanks for your help.

On 2024/8/19 下午 04:24, Krzysztof Kozlowski wrote:
>
> On Mon, Aug 19, 2024 at 04:08:58PM +0800, Jammy Huang wrote:
> > The Video Engine block in ASPEED Silicon SoCs is responsible for video
> > compressions with a wide range of video quality and compression ratio
> > options. It can capture and compress video data from digital or analog
> > sources.
> >
> > Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
> > ---
> >  .../bindings/arm/aspeed/aspeed,video.yaml     | 81
> +++++++++++++++++++
>
> Why are you adding duplicated binding? Please read the first comments - you
> need to first convert TXT to DT schema. Then you add new properties in a new
> patch.
Sorry, I didn't notice there is already a TXT in Documentation/devicetree/bindings/media.

>
> >  1 file changed, 81 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/arm/aspeed/aspeed,video.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/arm/aspeed/aspeed,video.yaml
> > b/Documentation/devicetree/bindings/arm/aspeed/aspeed,video.yaml
> > new file mode 100644
> > index 000000000000..bef7bd2f310a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed,video.yaml
>
> Filename matching compatible.
OK, rename to 'aspeed, video-engine.yaml' in next patch.

>
> > @@ -0,0 +1,81 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/aspeed/aspeed,video.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ASPEED Video Engine
>
> ASPEED or Aspeed?
I prefer ASPEED.

>
> > +
> > +maintainers:
> > +  - Eddie James <eajames@linux.ibm.com>
> > +  - Jammy Huang <jammy_huang@aspeedtech.com>
> > +
> > +description: |
>
> Drop |
OK

>
> > +  The ASPEED video engine can be configured to capture and compress
> > + video  data from digital or analog sources.
> > +
> > +select:
> > +  properties:
> > +    compatible:
> > +      pattern: "^aspeed,ast[0-9]+-video-engine$"
> > +  required:
> > +    - compatible
>
> Drop entire select. No clue what is this.
OK

>
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - description: Preferred naming style for compatibles of video
> components
> > +        pattern: "^aspeed,ast[0-9]+-video-engine$"
>
> ???
>
> No, drop.
OK

>
> > +
> > +      - enum:
> > +          - aspeed,ast2400-video-engine
> > +          - aspeed,ast2500-video-engine
> > +          - aspeed,ast2600-video-engine
> > +
> > +  reg:
> > +    minItems: 1
>
> No, maxItems.
OK

>
> > +
> > +  clocks:
> > +    minItems: 2
>
> No. maxItems.
OK

>
> > +
> > +  clock-names:
> > +    items:
> > +      - const: vclk
> > +      - const: eclk
> > +
> > +  interrupts:
> > +    minItems: 1
>
> maxItems
OK

>
> > +
> > +  aspeed,scu:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description: |
> > +      Specifies the scu node that is needed if video wants to capture
> > +      from sources other than Host VGA.
> > +
> > +  aspeed,gfx:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description: |
> > +      Specifies the Soc Display(gfx) node that needs to be queried to get
> > +      related information if video wants to use gfx as capture source.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - clock-names
> > +  - interrupts
> > +
> > +additionalProperties: true
>
> NAK, this cannot be true. Where do you see any device binding having it true?
OK

>
>
> > +
> > +examples:
> > +  - |
> > +    video: video@1e700000 {
>
> Drop unused label
OK

>
> > +           compatible = "aspeed,ast2600-video-engine";
>
> Fix indentation, this is supposed 4 spaces.
OK
************* Email Confidentiality Notice ********************
免責聲明:
本信件(或其附件)可能包含機密資訊,並受法律保護。如 台端非指定之收件者,請以電子郵件通知本電子郵件之發送者, 並請立即刪除本電子郵件及其附件和銷毀所有複印件。謝謝您的合作!

DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
Krzysztof Kozlowski Aug. 23, 2024, 6:13 a.m. UTC | #3
On 23/08/2024 03:11, Jammy Huang wrote:

> 
>>
>>> @@ -0,0 +1,81 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/arm/aspeed/aspeed,video.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: ASPEED Video Engine
>>
>> ASPEED or Aspeed?
> I prefer ASPEED.

What is the name of the company? How is it called in all bindings? Is it
an acronym?

> 
>>
>>> +
>>> +maintainers:
>>> +  - Eddie James <eajames@linux.ibm.com>
>>> +  - Jammy Huang <jammy_huang@aspeedtech.com>
>>> +
>>> +descriptio


...

> 
>>
>>> +           compatible = "aspeed,ast2600-video-engine";
>>
>> Fix indentation, this is supposed 4 spaces.
> OK
> ************* Email Confidentiality Notice ********************
> 免責聲明:
> 本信件(或其附件)可能包含機密資訊,並受法律保護。如 台端非指定之收件者,請以電子郵件通知本電子郵件之發送者, 並請立即刪除本電子郵件及其附件和銷毀所有複印件。謝謝您的合作!
> 
> DISCLAIMER:
> This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.


Every damn time from Aspeed. People, fix it finally. If you keep sending
confidential data, I will be rejecting/NAKing and deleting your messages
as requested.

<form letter>
Maybe I am the intended recipient of your message, maybe not. I don't
want to have any legal questions regarding upstream, public
collaboration, thus probably I should just remove your messages.

Please talk with your IT that such disclaimers in open-source are not
desired (and maybe even harmful).
If you do not understand why, please also see:
https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835

If you need to go around company SMTP server, then consider using b4
web-relay: https://b4.docs.kernel.org/en/latest/contributor/send.html

Please be informed that by responding to this email you agree that all
communications from you and/or your company is made public. In other
words, all messages originating from you and/or your company will be
made public.
<form letter>

Best regards,
Krzysztof
Jammy Huang Aug. 28, 2024, 6:05 a.m. UTC | #4
Hi Krzysztof,

Sorry for the troublesome e-mail notice. We have informed IT to remove it.

On 2024/8/23 下午 02:13, Krzysztof Kozlowski wrote:
> On 23/08/2024 03:11, Jammy Huang wrote:
> 
> >
> >>
> >>> @@ -0,0 +1,81 @@
> >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> >>> +---
> >>> +$id: http://devicetree.org/schemas/arm/aspeed/aspeed,video.yaml#
> >>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >>> +
> >>> +title: ASPEED Video Engine
> >>
> >> ASPEED or Aspeed?
> > I prefer ASPEED.
> 
> What is the name of the company? How is it called in all bindings? Is it an
> acronym?
It's ASPEED Technology Inc. You can find brief introduction here, https://www.aspeedtech.com/about_vision/.
I did check it in bindings, but both ASPEED and Aspeed can be found.
If you have suggestion, please let me know.
> 
> >
> >>
> >>> +
> >>> +maintainers:
> >>> +  - Eddie James <eajames@linux.ibm.com>
> >>> +  - Jammy Huang <jammy_huang@aspeedtech.com>
> >>> +
> >>> +descriptio
> 
> 
> ...
Typo. Will be fixed.

> 
> >
> >>
> >>> +           compatible = "aspeed,ast2600-video-engine";
> >>
> >> Fix indentation, this is supposed 4 spaces.
> > OK
> 
> Every damn time from Aspeed. People, fix it finally. If you keep sending
> confidential data, I will be rejecting/NAKing and deleting your messages as
> requested.
> 
> <form letter>
> Maybe I am the intended recipient of your message, maybe not. I don't want to
> have any legal questions regarding upstream, public collaboration, thus
> probably I should just remove your messages.
> 
> Please talk with your IT that such disclaimers in open-source are not desired
> (and maybe even harmful).
> If you do not understand why, please also see:
> https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835
> 
> If you need to go around company SMTP server, then consider using b4
> web-relay: https://b4.docs.kernel.org/en/latest/contributor/send.html
> 
> Please be informed that by responding to this email you agree that all
> communications from you and/or your company is made public. In other words,
> all messages originating from you and/or your company will be made public.
> <form letter>
> 
> Best regards,
> Krzysztof
Krzysztof Kozlowski Aug. 28, 2024, 9:10 a.m. UTC | #5
On 28/08/2024 08:05, Jammy Huang wrote:
> Hi Krzysztof,
> 
> Sorry for the troublesome e-mail notice. We have informed IT to remove it.
> 
> On 2024/8/23 下午 02:13, Krzysztof Kozlowski wrote:
>> On 23/08/2024 03:11, Jammy Huang wrote:
>>
>>>
>>>>
>>>>> @@ -0,0 +1,81 @@
>>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
>>>>> +---
>>>>> +$id: http://devicetree.org/schemas/arm/aspeed/aspeed,video.yaml#
>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>>> +
>>>>> +title: ASPEED Video Engine
>>>>
>>>> ASPEED or Aspeed?
>>> I prefer ASPEED.
>>
>> What is the name of the company? How is it called in all bindings? Is it an
>> acronym?
> It's ASPEED Technology Inc. You can find brief introduction here, https://www.aspeedtech.com/about_vision/.
> I did check it in bindings, but both ASPEED and Aspeed can be found.
> If you have suggestion, please let me know.

Keep official name, so ASPEED.



Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed,video.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed,video.yaml
new file mode 100644
index 000000000000..bef7bd2f310a
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed,video.yaml
@@ -0,0 +1,81 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/aspeed/aspeed,video.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ASPEED Video Engine
+
+maintainers:
+  - Eddie James <eajames@linux.ibm.com>
+  - Jammy Huang <jammy_huang@aspeedtech.com>
+
+description: |
+  The ASPEED video engine can be configured to capture and compress video
+  data from digital or analog sources.
+
+select:
+  properties:
+    compatible:
+      pattern: "^aspeed,ast[0-9]+-video-engine$"
+  required:
+    - compatible
+
+properties:
+  compatible:
+    oneOf:
+      - description: Preferred naming style for compatibles of video components
+        pattern: "^aspeed,ast[0-9]+-video-engine$"
+
+      - enum:
+          - aspeed,ast2400-video-engine
+          - aspeed,ast2500-video-engine
+          - aspeed,ast2600-video-engine
+
+  reg:
+    minItems: 1
+
+  clocks:
+    minItems: 2
+
+  clock-names:
+    items:
+      - const: vclk
+      - const: eclk
+
+  interrupts:
+    minItems: 1
+
+  aspeed,scu:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: |
+      Specifies the scu node that is needed if video wants to capture
+      from sources other than Host VGA.
+
+  aspeed,gfx:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: |
+      Specifies the Soc Display(gfx) node that needs to be queried to get
+      related information if video wants to use gfx as capture source.
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - interrupts
+
+additionalProperties: true
+
+examples:
+  - |
+    video: video@1e700000 {
+          	compatible = "aspeed,ast2600-video-engine";
+          	reg = <0x1e700000 0x1000>;
+          	clocks = <&syscon ASPEED_CLK_GATE_VCLK>,
+          	         <&syscon ASPEED_CLK_GATE_ECLK>;
+          	clock-names = "vclk", "eclk";
+          	interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+          	aspeed,scu = <&syscon>;
+          	aspeed,gfx = <&gfx>;
+    };