Message ID | 20240326103549.2413515-2-Kelly_Hung@asus.com |
---|---|
State | New |
Headers | show |
Series | Add Reviewed-by and Acked-by tags | expand |
On Tue, Mar 26, 2024 at 12:36:50PM +0100, Krzysztof Kozlowski wrote: > On 26/03/2024 11:35, Kelly Hung wrote: > > Document the new compatibles used on ASUS X4TF. > > > > Signed-off-by: Kelly Hung <Kelly_Hung@asus.com> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Reviewed-by: Rob Herring <robh@kernel.org> > > Where did it happen? Where did you receive this tag? Please provide link > to lore. Robh's bot sent two reports, but I do not see a tag: https://lore.kernel.org/all/?q=c%3AKelly_Hung%40asus.com+f%3Arobh > > Reviewed-by: Zev Weiss <zweiss@equinix.com> > > Where did it happen? Where did you receive this tag? Please provide link > to lore. Zev seems to have left a comment on this, but not provided a tag: https://lore.kernel.org/all/20240223220115.GB9299@packtop/ Kelly, it is important that you do not add tags unless someone gives them to you explicitly. Thanks, Conor.
On Tue, 2024-03-26 at 18:35 +0800, Kelly Hung wrote: > Document the new compatibles used on ASUS X4TF. > > Signed-off-by: Kelly Hung <Kelly_Hung@asus.com> In addition to the concerns of others, your author email is not the same as your SoB email. checkpatch warns: ``` WARNING: From:/Signed-off-by: email address mismatch: 'From: Kelly Hung <ppighouse@gmail.com>' != 'Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>' total: 0 errors, 1 warnings, 7 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix- inplace. Commit bb035db4c70a ("dt-bindings: arm: aspeed: add ASUS X4TF board") has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ``` Please fix this issue for both patches in the series and resend. Thanks, Andrew
diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index 749ee54a3..0047eb4ab 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -74,6 +74,7 @@ properties: - ampere,mtmitchell-bmc - aspeed,ast2600-evb - aspeed,ast2600-evb-a1 + - asus,x4tf-bmc - facebook,bletchley-bmc - facebook,cloudripper-bmc - facebook,elbert-bmc