| Message ID | 20240210-bus_cleanup-peci-v1-1-1e64bef6efc0@marliere.net |
|---|---|
| State | New |
| Headers | show |
| Series | peci: Make peci_bus_type const | expand |
On Sat, 2024-02-10 at 12:10 -0300, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the peci_bus_type variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> Reviewed-by: Iwona Winiarska <iwona.winiarska@intel.com> Thanks -Iwona > --- > drivers/peci/core.c | 2 +- > drivers/peci/internal.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/peci/core.c b/drivers/peci/core.c > index 0f83a9c6093b..b2f8db967e9b 100644 > --- a/drivers/peci/core.c > +++ b/drivers/peci/core.c > @@ -201,7 +201,7 @@ static void peci_bus_device_remove(struct device *dev) > driver->remove(device); > } > > -struct bus_type peci_bus_type = { > +const struct bus_type peci_bus_type = { > .name = "peci", > .match = peci_bus_device_match, > .probe = peci_bus_device_probe, > diff --git a/drivers/peci/internal.h b/drivers/peci/internal.h > index 9d75ea54504c..8a896c256c5f 100644 > --- a/drivers/peci/internal.h > +++ b/drivers/peci/internal.h > @@ -81,7 +81,7 @@ extern const struct attribute_group *peci_device_groups[]; > int peci_device_create(struct peci_controller *controller, u8 addr); > void peci_device_destroy(struct peci_device *device); > > -extern struct bus_type peci_bus_type; > +extern const struct bus_type peci_bus_type; > extern const struct attribute_group *peci_bus_groups[]; > > /** > > --- > base-commit: 047371968ffc470769f541d6933e262dc7085456 > change-id: 20240210-bus_cleanup-peci-0933c629d58b > > Best regards,
diff --git a/drivers/peci/core.c b/drivers/peci/core.c index 0f83a9c6093b..b2f8db967e9b 100644 --- a/drivers/peci/core.c +++ b/drivers/peci/core.c @@ -201,7 +201,7 @@ static void peci_bus_device_remove(struct device *dev) driver->remove(device); } -struct bus_type peci_bus_type = { +const struct bus_type peci_bus_type = { .name = "peci", .match = peci_bus_device_match, .probe = peci_bus_device_probe, diff --git a/drivers/peci/internal.h b/drivers/peci/internal.h index 9d75ea54504c..8a896c256c5f 100644 --- a/drivers/peci/internal.h +++ b/drivers/peci/internal.h @@ -81,7 +81,7 @@ extern const struct attribute_group *peci_device_groups[]; int peci_device_create(struct peci_controller *controller, u8 addr); void peci_device_destroy(struct peci_device *device); -extern struct bus_type peci_bus_type; +extern const struct bus_type peci_bus_type; extern const struct attribute_group *peci_bus_groups[]; /**
Now that the driver core can properly handle constant struct bus_type, move the peci_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> --- drivers/peci/core.c | 2 +- drivers/peci/internal.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- base-commit: 047371968ffc470769f541d6933e262dc7085456 change-id: 20240210-bus_cleanup-peci-0933c629d58b Best regards,