diff mbox series

[v4,1/2] soc: nuvoton: Add a menu for Nuvoton SoC drivers

Message ID 20230814173757.1747439-1-j.neuschaefer@gmx.net
State New
Headers show
Series [v4,1/2] soc: nuvoton: Add a menu for Nuvoton SoC drivers | expand

Commit Message

J. Neuschäfer Aug. 14, 2023, 5:37 p.m. UTC
Add a menu "Nuvoton SoC drivers" to make it easier to add other Nuvoton
SoC drivers later on and to prevent asking about the Nuvoton WPCM450 SoC
driver when configuring a kernel without support for Nuvoton SoCs.

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Closes: https://lore.kernel.org/lkml/CAMuHMdWo5vHCeE6BeSHrUy12uT7_wFhW-VbQmQ5u+4Q8c7-wYQ@mail.gmail.com/
Fixes: 7dbb4a38bff3 ("soc: nuvoton: Add SoC info driver for WPCM450")
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v4:
- Add Geert's tag
- Fix commit reference
- Change Link tag to Closes

v3:
- Split the commit into two
- Reword the commit messages a bit

v2:
- https://lore.kernel.org/lkml/20230212215234.2608565-1-j.neuschaefer@gmx.net/
- Commit message improvements, as suggested by Geert Uytterhoeven.
- Add Link after Reviewed-by, as checkpatch.pl now suggests
---
 drivers/soc/nuvoton/Kconfig | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

--
2.40.1

Comments

Geert Uytterhoeven Sept. 19, 2023, 11:37 a.m. UTC | #1
Hi Jonathan,

On Mon, Aug 14, 2023 at 7:38 PM Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:
> Add a menu "Nuvoton SoC drivers" to make it easier to add other Nuvoton
> SoC drivers later on and to prevent asking about the Nuvoton WPCM450 SoC
> driver when configuring a kernel without support for Nuvoton SoCs.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Closes: https://lore.kernel.org/lkml/CAMuHMdWo5vHCeE6BeSHrUy12uT7_wFhW-VbQmQ5u+4Q8c7-wYQ@mail.gmail.com/
> Fixes: 7dbb4a38bff3 ("soc: nuvoton: Add SoC info driver for WPCM450")
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v4:
> - Add Geert's tag
> - Fix commit reference
> - Change Link tag to Closes

Any plans to move this patch and patch 2/2 forward?
Thanks!

Gr{oetje,eeting}s,

                        Geert
J. Neuschäfer Sept. 19, 2023, 8:38 p.m. UTC | #2
On Tue, Sep 19, 2023 at 01:37:01PM +0200, Geert Uytterhoeven wrote:
> Hi Jonathan,
> 
> On Mon, Aug 14, 2023 at 7:38 PM Jonathan Neuschäfer
> <j.neuschaefer@gmx.net> wrote:
> > Add a menu "Nuvoton SoC drivers" to make it easier to add other Nuvoton
> > SoC drivers later on and to prevent asking about the Nuvoton WPCM450 SoC
> > driver when configuring a kernel without support for Nuvoton SoCs.
> >
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Closes: https://lore.kernel.org/lkml/CAMuHMdWo5vHCeE6BeSHrUy12uT7_wFhW-VbQmQ5u+4Q8c7-wYQ@mail.gmail.com/
> > Fixes: 7dbb4a38bff3 ("soc: nuvoton: Add SoC info driver for WPCM450")
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > v4:
> > - Add Geert's tag
> > - Fix commit reference
> > - Change Link tag to Closes
> 
> Any plans to move this patch and patch 2/2 forward?
> Thanks!

I've been distracted by other projects, but I still want to move this
patchset forward. I will hopefully get around to it by the end of this week.


Thanks for the reminder,
Jonathan
diff mbox series

Patch

diff --git a/drivers/soc/nuvoton/Kconfig b/drivers/soc/nuvoton/Kconfig
index df46182088ec2..853392c8a9151 100644
--- a/drivers/soc/nuvoton/Kconfig
+++ b/drivers/soc/nuvoton/Kconfig
@@ -1,5 +1,8 @@ 
 # SPDX-License-Identifier: GPL-2.0
-menuconfig WPCM450_SOC
+menu "Nuvoton SoC drivers"
+	depends on ARCH_NPCM || COMPILE_TEST
+
+config WPCM450_SOC
 	tristate "Nuvoton WPCM450 SoC driver"
 	default y if ARCH_WPCM450
 	select SOC_BUS
@@ -9,3 +12,5 @@  menuconfig WPCM450_SOC

 	  This driver provides information such as the SoC model and
 	  revision.
+
+endmenu