| Message ID | 20230727202126.1477515-4-iwona.winiarska@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for PECI Nuvoton | expand |
Hi Iwona, I have done r-b, Just could you do a small modification On Thu, 27 Jul 2023 at 23:23, Iwona Winiarska <iwona.winiarska@intel.com> wrote: > > Add PECI controller node with all required information. > > Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> > --- > arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi > index c7b5ef15b716..cccc33441050 100644 > --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi > +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi > @@ -220,6 +220,15 @@ kcs3: kcs3@0 { > }; > }; > > + peci0: peci-controller@f0100000 { Please modify the peci0 to peci we have only one PECI controller. > + compatible = "nuvoton,npcm750-peci"; > + reg = <0xf0100000 0x200>; > + interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk NPCM7XX_CLK_APB3>; > + cmd-timeout-ms = <1000>; > + status = "disabled"; > + }; > + > spi0: spi@200000 { > compatible = "nuvoton,npcm750-pspi"; > reg = <0x200000 0x1000>; > -- > 2.40.1 > Reviewed-by: Tomer Maimon <tmaimon77@gmail.com> Thanks, Tomer
On Tue, 2023-08-01 at 11:40 +0300, Tomer Maimon wrote: > Hi Iwona, > > I have done r-b, Just could you do a small modification > > On Thu, 27 Jul 2023 at 23:23, Iwona Winiarska <iwona.winiarska@intel.com> > wrote: > > > > Add PECI controller node with all required information. > > > > Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> > > --- > > arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi > > b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi > > index c7b5ef15b716..cccc33441050 100644 > > --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi > > +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi > > @@ -220,6 +220,15 @@ kcs3: kcs3@0 { > > }; > > }; > > > > + peci0: peci-controller@f0100000 { > Please modify the peci0 to peci we have only one PECI controller. I'll fix up both DTS files while applying to peci-next. Thanks -Iwona > > + compatible = "nuvoton,npcm750-peci"; > > + reg = <0xf0100000 0x200>; > > + interrupts = <GIC_SPI 6 > > IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&clk NPCM7XX_CLK_APB3>; > > + cmd-timeout-ms = <1000>; > > + status = "disabled"; > > + }; > > + > > spi0: spi@200000 { > > compatible = "nuvoton,npcm750-pspi"; > > reg = <0x200000 0x1000>; > > -- > > 2.40.1 > > > > Reviewed-by: Tomer Maimon <tmaimon77@gmail.com> > > Thanks, > > Tomer
diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi index c7b5ef15b716..cccc33441050 100644 --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi @@ -220,6 +220,15 @@ kcs3: kcs3@0 { }; }; + peci0: peci-controller@f0100000 { + compatible = "nuvoton,npcm750-peci"; + reg = <0xf0100000 0x200>; + interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk NPCM7XX_CLK_APB3>; + cmd-timeout-ms = <1000>; + status = "disabled"; + }; + spi0: spi@200000 { compatible = "nuvoton,npcm750-pspi"; reg = <0x200000 0x1000>;
Add PECI controller node with all required information. Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> --- arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)