| Message ID | 20230719220853.1029316-2-iwona.winiarska@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for PECI Nuvoton | expand |
On Thu, 2023-07-20 at 08:18 +0200, Krzysztof Kozlowski wrote: > On 20/07/2023 00:08, Iwona Winiarska wrote: > > From: Tomer Maimon <tmaimon77@gmail.com> > > > > Add device tree bindings for the peci-npcm controller driver. > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > Signed-off-by: Tyrone Ting <warp5tw@gmail.com> > > Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com> > > Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> > > --- > > No changes from previous versions? Nothing improved? This is the first submission. > > > .../devicetree/bindings/peci/peci-npcm.yaml | 56 +++++++++++++++++++ > > 1 file changed, 56 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/peci/peci-npcm.yaml > > Use compatible as filename. Sure - there are two compatible entries, so I'm going to change it to nuvoton,npcm-peci.yaml Thanks -Iwona > > Best regards, > Krzysztof >
On Thu, Jul 20, 2023 at 08:03:28AM +0000, Winiarska, Iwona wrote: > On Thu, 2023-07-20 at 08:18 +0200, Krzysztof Kozlowski wrote: > > On 20/07/2023 00:08, Iwona Winiarska wrote: > > > From: Tomer Maimon <tmaimon77@gmail.com> > > > > > > Add device tree bindings for the peci-npcm controller driver. > > > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > > Signed-off-by: Tyrone Ting <warp5tw@gmail.com> > > > Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com> > > > Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> > > > --- > > > > No changes from previous versions? Nothing improved? > > This is the first submission. 13th by my count. https://lore.kernel.org/all/20230616193450.413366-2-iwona.winiarska@intel.com/ https://lore.kernel.org/all/20191211194624.2872-8-jae.hyun.yoo@linux.intel.com/
On Mon, 2023-07-24 at 08:38 -0600, Rob Herring wrote: > On Thu, Jul 20, 2023 at 08:03:28AM +0000, Winiarska, Iwona wrote: > > On Thu, 2023-07-20 at 08:18 +0200, Krzysztof Kozlowski wrote: > > > On 20/07/2023 00:08, Iwona Winiarska wrote: > > > > From: Tomer Maimon <tmaimon77@gmail.com> > > > > > > > > Add device tree bindings for the peci-npcm controller driver. > > > > > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > > > Signed-off-by: Tyrone Ting <warp5tw@gmail.com> > > > > Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com> > > > > Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> > > > > --- > > > > > > No changes from previous versions? Nothing improved? > > > > This is the first submission. > > 13th by my count. > > https://lore.kernel.org/all/20230616193450.413366-2-iwona.winiarska@intel.com/ This was just a request for testing sent exclusively to openbmc mailinglist (and btw - there were no changes in between). > https://lore.kernel.org/all/20191211194624.2872-8-jae.hyun.yoo@linux.intel.com/ This is part of a series that contains whole, currently obsoleted, PECI subsystem, in a form that never got merged into mainline Linux. The PECI subsystem that is currently present in mainline Linux didn't include Nuvoton driver: https://lore.kernel.org/all/20220208153639.255278-1-iwona.winiarska@intel.com/ There is a subset of patches that is common between this submission and the obsoleted PECI subsystem series (the linked v11), but I don't see how continuing that numbering would provide any useful information to reviewers. Thanks -Iwona
diff --git a/Documentation/devicetree/bindings/peci/peci-npcm.yaml b/Documentation/devicetree/bindings/peci/peci-npcm.yaml new file mode 100644 index 000000000000..6eafa9ccaa54 --- /dev/null +++ b/Documentation/devicetree/bindings/peci/peci-npcm.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/peci/peci-npcm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton PECI Bus + +maintainers: + - Tomer Maimon <tmaimon77@gmail.com> + +allOf: + - $ref: peci-controller.yaml# + +properties: + compatible: + enum: + - nuvoton,npcm750-peci + - nuvoton,npcm845-peci + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + description: + Clock source for PECI controller. Should reference the APB clock. + maxItems: 1 + + cmd-timeout-ms: + minimum: 1 + maximum: 1000 + default: 1000 + +required: + - compatible + - reg + - interrupts + - clocks + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/nuvoton,npcm7xx-clock.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + peci-controller@f0100000 { + compatible = "nuvoton,npcm750-peci"; + reg = <0xf0100000 0x200>; + interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk NPCM7XX_CLK_APB3>; + cmd-timeout-ms = <1000>; + }; +...