| Message ID | 20230628090404.234965-2-tmaimon77@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for PECI Nuvoton | expand |
On 28/06/2023 11:04, Tomer Maimon wrote: > Add device tree bindings for the peci-npcm controller driver. > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > Signed-off-by: kfting <warp5tw@gmail.com> > Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com> > Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> My patch tracker found it, but the commit msg suggests this is not for Linux. I mean, you did not intend this patch to be merged into Linux kernel, right? Cover letter does not explain here anything. If so, please ignore. If not and you actually added some dev-6.1 by mistake, then regular disclaimer follows: A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least DT list (maybe more), so this won't be tested by our tools. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. The sad part is that I already said it to Iwona. I wonder if all the comments were ignored or something was fixed? Best regards, Krzysztof
Hi Krzysztof, This patch sends to the OpenBMC Linux kernel and not to the Linux kernel vanilla upstream, this is why I added in the message dev-6.1 and only send it to the OpenBMC mail list, please ignore it. https://github.com/openbmc/linux Thanks, Tomer On Sun, 2 Jul 2023 at 12:30, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 28/06/2023 11:04, Tomer Maimon wrote: > > Add device tree bindings for the peci-npcm controller driver. > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > Signed-off-by: kfting <warp5tw@gmail.com> > > Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com> > > Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> > > My patch tracker found it, but the commit msg suggests this is not for > Linux. I mean, you did not intend this patch to be merged into Linux > kernel, right? Cover letter does not explain here anything. > > If so, please ignore. > > If not and you actually added some dev-6.1 by mistake, then regular > disclaimer follows: > > A nit, subject: drop second/last, redundant "bindings". The > "dt-bindings" prefix is already stating that these are bindings. > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > You missed at least DT list (maybe more), so this won't be tested by our > tools. Performing review on untested code might be a waste of time, thus > I will skip this patch entirely till you follow the process allowing the > patch to be tested. > > Please kindly resend and include all necessary To/Cc entries. > > > The sad part is that I already said it to Iwona. I wonder if all the > comments were ignored or something was fixed? > > Best regards, > Krzysztof >
On 02/07/2023 16:14, Tomer Maimon wrote: > Hi Krzysztof, > > This patch sends to the OpenBMC Linux kernel and not to the Linux > kernel vanilla upstream, this is why I added in the message dev-6.1 > and only send it to the OpenBMC mail list, please ignore it. > https://github.com/openbmc/linux > Sure, no problem. Sorry for the noise. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/peci/peci-npcm.yaml b/Documentation/devicetree/bindings/peci/peci-npcm.yaml new file mode 100644 index 000000000000..f82a6ed3a3d3 --- /dev/null +++ b/Documentation/devicetree/bindings/peci/peci-npcm.yaml @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/peci/peci-npcm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton PECI Bus + +maintainers: + - Tomer Maimon <tmaimon77@gmail.com> + +allOf: + - $ref: peci-controller.yaml# + +properties: + compatible: + enum: + - nuvoton,npcm750-peci + - nuvoton,npcm845-peci + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + description: + Clock source for PECI controller. Should reference the APB + clock. + maxItems: 1 + + cmd-timeout-ms: + minimum: 1 + maximum: 1000 + default: 1000 + +required: + - compatible + - reg + - interrupts + - clocks + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/nuvoton,npcm7xx-clock.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + peci-controller@f0100000 { + compatible = "nuvoton,npcm750-peci"; + reg = <0xf0100000 0x200>; + interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk NPCM7XX_CLK_APB3>; + cmd-timeout-ms = <1000>; + }; +...