| Message ID | 20230616193450.413366-2-iwona.winiarska@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for PECI Nuvoton | expand |
On 16/06/2023 21:34, Iwona Winiarska wrote: > From: Tomer Maimon <tmaimon77@gmail.com> > > Add device tree bindings for the peci-npcm controller driver. > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > Signed-off-by: kfting <warp5tw@gmail.com> > Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com> > Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least DT list (maybe more), so this won't be tested by our tools. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. Best regards, Krzysztof
On Sat, 2023-06-17 at 09:48 +0200, Krzysztof Kozlowski wrote: > On 16/06/2023 21:34, Iwona Winiarska wrote: > > From: Tomer Maimon <tmaimon77@gmail.com> > > > > Add device tree bindings for the peci-npcm controller driver. > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > Signed-off-by: kfting <warp5tw@gmail.com> > > Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com> > > Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > You missed at least DT list (maybe more), so this won't be tested by our > tools. Performing review on untested code might be a waste of time, thus > I will skip this patch entirely till you follow the process allowing the > patch to be tested. That was the idea behind marking it as "RFT", adding a note that "I wasn't able to test it on a real hardware so I would like to ask for help to test it on Nuvoton systems." in the cover letter, and sending it exclusively to OpenBMC mailinglist - to avoid wasting time on review before someone has a chance to run it on Nuvoton hardware. -Iwona > > Please kindly resend and include all necessary To/Cc entries. > > > Best regards, > Krzysztof >
On 17/06/2023 23:21, Winiarska, Iwona wrote: > On Sat, 2023-06-17 at 09:48 +0200, Krzysztof Kozlowski wrote: >> On 16/06/2023 21:34, Iwona Winiarska wrote: >>> From: Tomer Maimon <tmaimon77@gmail.com> >>> >>> Add device tree bindings for the peci-npcm controller driver. >>> >>> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> >>> Signed-off-by: kfting <warp5tw@gmail.com> >>> Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com> >>> Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> >> >> Please use scripts/get_maintainers.pl to get a list of necessary people >> and lists to CC. It might happen, that command when run on an older >> kernel, gives you outdated entries. Therefore please be sure you base >> your patches on recent Linux kernel. >> >> You missed at least DT list (maybe more), so this won't be tested by our >> tools. Performing review on untested code might be a waste of time, thus >> I will skip this patch entirely till you follow the process allowing the >> patch to be tested. > > That was the idea behind marking it as "RFT", adding a note that "I wasn't able > to test it on a real hardware so I would like to ask for help to test it on > Nuvoton systems." Which does not explain sending patch incorrect patch or patch which automation cannot test. > in the cover letter, and sending it exclusively to OpenBMC > mailinglist - to avoid wasting time on review before someone has a chance to run > it on Nuvoton hardware. Usually such patches after receiving tested tags are immediately applied, so in that case your patch would be applied without review and our automation testing. Anyway, fine, to be clear it cannot be applied: NAK, patch is not correct Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/peci/peci-npcm.yaml b/Documentation/devicetree/bindings/peci/peci-npcm.yaml new file mode 100644 index 000000000000..6eafa9ccaa54 --- /dev/null +++ b/Documentation/devicetree/bindings/peci/peci-npcm.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/peci/peci-npcm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton PECI Bus + +maintainers: + - Tomer Maimon <tmaimon77@gmail.com> + +allOf: + - $ref: peci-controller.yaml# + +properties: + compatible: + enum: + - nuvoton,npcm750-peci + - nuvoton,npcm845-peci + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + description: + Clock source for PECI controller. Should reference the APB clock. + maxItems: 1 + + cmd-timeout-ms: + minimum: 1 + maximum: 1000 + default: 1000 + +required: + - compatible + - reg + - interrupts + - clocks + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/nuvoton,npcm7xx-clock.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + peci-controller@f0100000 { + compatible = "nuvoton,npcm750-peci"; + reg = <0xf0100000 0x200>; + interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk NPCM7XX_CLK_APB3>; + cmd-timeout-ms = <1000>; + }; +...