diff mbox series

[v1] reset: npcm: fix iprst2 and iprst4 setting

Message ID 20220922153856.23326-1-tmaimon77@gmail.com
State New
Headers show
Series [v1] reset: npcm: fix iprst2 and iprst4 setting | expand

Commit Message

Tomer Maimon Sept. 22, 2022, 3:38 p.m. UTC
In NPCM8XX USB reset sequence, iprst2 register was set with iprst4 value
and iprst4 register wasn´t set.

This fix sets the correct IP reset values in iprst2 and iprst4 registers
in NPCM8XX USB reset sequence.

Fixes: fc5d2a2f4aa5 ("reset: npcm: Add NPCM8XX support")

Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
 drivers/reset/reset-npcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philipp Zabel Sept. 22, 2022, 3:49 p.m. UTC | #1
On Do, 2022-09-22 at 18:38 +0300, Tomer Maimon wrote:
> In NPCM8XX USB reset sequence, iprst2 register was set with iprst4 value
> and iprst4 register wasn´t set.
> 
> This fix sets the correct IP reset values in iprst2 and iprst4 registers
> in NPCM8XX USB reset sequence.
> 
> Fixes: fc5d2a2f4aa5 ("reset: npcm: Add NPCM8XX support")
> 
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>

Thank you, applied to reset/fixes.

regards
Philipp
diff mbox series

Patch

diff --git a/drivers/reset/reset-npcm.c b/drivers/reset/reset-npcm.c
index 24c55efa98e5..f2333506b0a6 100644
--- a/drivers/reset/reset-npcm.c
+++ b/drivers/reset/reset-npcm.c
@@ -291,7 +291,7 @@  static void npcm_usb_reset_npcm8xx(struct npcm_rc_data *rc)
 	iprst2 |= ipsrst2_bits;
 	iprst3 |= (ipsrst3_bits | NPCM_IPSRST3_USBPHY1 |
 		   NPCM_IPSRST3_USBPHY2);
-	iprst2 |= ipsrst4_bits;
+	iprst4 |= ipsrst4_bits;
 
 	writel(iprst1, rc->base + NPCM_IPSRST1);
 	writel(iprst2, rc->base + NPCM_IPSRST2);