Message ID | 20220203133736.246397-2-j.neuschaefer@gmx.net |
---|---|
State | New |
Headers | show |
Series | Fixing the compile-test warnings in pinctrl-npcm7xx | expand |
On Thu, Feb 3, 2022 at 3:37 PM Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > > When compile-testing on 64-bit architectures, GCC complains about the > mismatch of types between the %d format specifier and value returned by > ARRAY_LENGTH(). Use %zd, which is correct everywhere. > > Reported-by: kernel test robot <lkp@intel.com> > Fixes: 3b588e43ee5c7 ("pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver") > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> ... > - dev_dbg(npcm->dev, "group size: %d\n", ARRAY_SIZE(npcm7xx_groups)); > + dev_dbg(npcm->dev, "group size: %zd\n", ARRAY_SIZE(npcm7xx_groups)); Dunno how it's slipped away, but the proper specifier is %zu. I guess that's what I also mentioned in reply to LKP's report.
On Thu, Feb 03, 2022 at 04:16:56PM +0200, Andy Shevchenko wrote: > On Thu, Feb 3, 2022 at 3:37 PM Jonathan Neuschäfer > <j.neuschaefer@gmx.net> wrote: > > > > When compile-testing on 64-bit architectures, GCC complains about the > > mismatch of types between the %d format specifier and value returned by > > ARRAY_LENGTH(). Use %zd, which is correct everywhere. > > > > Reported-by: kernel test robot <lkp@intel.com> > > Fixes: 3b588e43ee5c7 ("pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver") > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > ... > > > - dev_dbg(npcm->dev, "group size: %d\n", ARRAY_SIZE(npcm7xx_groups)); > > + dev_dbg(npcm->dev, "group size: %zd\n", ARRAY_SIZE(npcm7xx_groups)); > > Dunno how it's slipped away, but the proper specifier is %zu. Right, I should have noticed that. > I guess that's what I also mentioned in reply to LKP's report. True, >> Should be %zu Thanks, Jonathan
diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c index 4d81908d6725d..705576e03e334 100644 --- a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c +++ b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c @@ -1561,7 +1561,7 @@ static int npcm7xx_get_groups_count(struct pinctrl_dev *pctldev) { struct npcm7xx_pinctrl *npcm = pinctrl_dev_get_drvdata(pctldev); - dev_dbg(npcm->dev, "group size: %d\n", ARRAY_SIZE(npcm7xx_groups)); + dev_dbg(npcm->dev, "group size: %zd\n", ARRAY_SIZE(npcm7xx_groups)); return ARRAY_SIZE(npcm7xx_groups); }