diff mbox series

[linux,dev-5.10,13/35] dt: bindings: mmc: Add phase control properties for the Aspeed SDHCI

Message ID 20210308225419.46530-14-eajames@linux.ibm.com
State New
Headers show
Series Rainier and Everest system updates | expand

Commit Message

Eddie James March 8, 2021, 10:53 p.m. UTC
From: Andrew Jeffery <andrew@aj.id.au>

Add properties to control the phase delay for input and output data
sampling.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---
 Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Joel Stanley March 12, 2021, 12:19 a.m. UTC | #1
On Mon, 8 Mar 2021 at 22:54, Eddie James <eajames@linux.ibm.com> wrote:
>
> From: Andrew Jeffery <andrew@aj.id.au>
>
> Add properties to control the phase delay for input and output data
> sampling.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Andrew, can you please review this and the other mmc related device
tree changes in this series.

I'm particularly interested in the upstream state of these changes.

> ---
>  Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> index 987b287f3bff..ebcb9ed4e308 100644
> --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> @@ -37,6 +37,14 @@ properties:
>    clocks:
>      maxItems: 1
>      description: The SD/SDIO controller clock gate
> +  "aspeed,input-phase":
> +    $ref: '/schemas/types.yaml#/definitions/uint32'
> +    description:
> +      The input clock phase delay value.
> +  "aspeed,output-phase":
> +    $ref: '/schemas/types.yaml#/definitions/uint32'
> +    description:
> +      The output clock phase delay value.
>
>  patternProperties:
>    "^sdhci@[0-9a-f]+$":
> --
> 2.27.0
>
Andrew Jeffery April 12, 2021, 3:21 a.m. UTC | #2
On Fri, 12 Mar 2021, at 10:49, Joel Stanley wrote:
> On Mon, 8 Mar 2021 at 22:54, Eddie James <eajames@linux.ibm.com> wrote:
> >
> > From: Andrew Jeffery <andrew@aj.id.au>
> >
> > Add properties to control the phase delay for input and output data
> > sampling.
> >
> > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> 
> Andrew, can you please review this and the other mmc related device
> tree changes in this series.
> 
> I'm particularly interested in the upstream state of these changes.

I've got MMC phase support for the Aspeed driver upstream in 5.12. We 
should backport those changes instead.

Andrew
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
index 987b287f3bff..ebcb9ed4e308 100644
--- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
@@ -37,6 +37,14 @@  properties:
   clocks:
     maxItems: 1
     description: The SD/SDIO controller clock gate
+  "aspeed,input-phase":
+    $ref: '/schemas/types.yaml#/definitions/uint32'
+    description:
+      The input clock phase delay value.
+  "aspeed,output-phase":
+    $ref: '/schemas/types.yaml#/definitions/uint32'
+    description:
+      The output clock phase delay value.
 
 patternProperties:
   "^sdhci@[0-9a-f]+$":