| Message ID | 20210129175435.2241080-1-msbarth@linux.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [linux,dev-5.8] pmbus:max31785: Support revision "B" | expand |
On Sat, 30 Jan 2021, at 04:24, Matthew Barth wrote: > There was an issue in how the tach feedbacks of dual rotor fans were > reported during any change in fan speeds with revision "A" of the > MAX31785. When the fan speeds would transition to a new target speed, > the rotor not wired to the TACH input when TACHSEL = 0 would report a > speed of 0 until the new target was reached. This has been fixed, > resulting in a revision "B" update where the MFR_REVISION of "B" is > 0x3061. > > Signed-off-by: Matthew Barth <msbarth@linux.ibm.com> Can you please send this upstream? Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
On Sun, 31 Jan 2021 at 22:46, Andrew Jeffery <andrew@aj.id.au> wrote: > > > > On Sat, 30 Jan 2021, at 04:24, Matthew Barth wrote: > > There was an issue in how the tach feedbacks of dual rotor fans were > > reported during any change in fan speeds with revision "A" of the > > MAX31785. When the fan speeds would transition to a new target speed, > > the rotor not wired to the TACH input when TACHSEL = 0 would report a > > speed of 0 until the new target was reached. This has been fixed, > > resulting in a revision "B" update where the MFR_REVISION of "B" is > > 0x3061. > > > > Signed-off-by: Matthew Barth <msbarth@linux.ibm.com> > > Can you please send this upstream? +1, I'll merge this into the openbmc tree once you've had it reviewed upstream. Cheers, Joel > > Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
On 1/31/21 4:46 PM, Andrew Jeffery wrote: > > On Sat, 30 Jan 2021, at 04:24, Matthew Barth wrote: >> There was an issue in how the tach feedbacks of dual rotor fans were >> reported during any change in fan speeds with revision "A" of the >> MAX31785. When the fan speeds would transition to a new target speed, >> the rotor not wired to the TACH input when TACHSEL = 0 would report a >> speed of 0 until the new target was reached. This has been fixed, >> resulting in a revision "B" update where the MFR_REVISION of "B" is >> 0x3061. >> >> Signed-off-by: Matthew Barth <msbarth@linux.ibm.com> > Can you please send this upstream? Will do. Didn't realize this driver had got accepted upstream. Matt > > Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
On Mon, 1 Feb 2021 at 14:14, Matthew Barth <msbarth@linux.ibm.com> wrote: > > > On 1/31/21 4:46 PM, Andrew Jeffery wrote: > > > > On Sat, 30 Jan 2021, at 04:24, Matthew Barth wrote: > >> There was an issue in how the tach feedbacks of dual rotor fans were > >> reported during any change in fan speeds with revision "A" of the > >> MAX31785. When the fan speeds would transition to a new target speed, > >> the rotor not wired to the TACH input when TACHSEL = 0 would report a > >> speed of 0 until the new target was reached. This has been fixed, > >> resulting in a revision "B" update where the MFR_REVISION of "B" is > >> 0x3061. > >> > >> Signed-off-by: Matthew Barth <msbarth@linux.ibm.com> > > Can you please send this upstream? > > Will do. Didn't realize this driver had got accepted upstream. Thanks. I've merged the version that Guneter committed upstream. Cheers, Joel
diff --git a/drivers/hwmon/pmbus/max31785.c b/drivers/hwmon/pmbus/max31785.c index cbcd0b2301f4..4de226670069 100644 --- a/drivers/hwmon/pmbus/max31785.c +++ b/drivers/hwmon/pmbus/max31785.c @@ -20,6 +20,7 @@ enum max31785_regs { #define MAX31785 0x3030 #define MAX31785A 0x3040 +#define MAX31785B 0x3061 #define MFR_FAN_CONFIG_DUAL_TACH BIT(12) #define MFR_FAN_CONFIG_TSFO BIT(9) @@ -749,12 +750,13 @@ static int max31785_probe(struct i2c_client *client, if (ret < 0) return ret; - if (ret == MAX31785A) { + if (ret == MAX31785A || ret == MAX31785B) { dual_tach = true; } else if (ret == MAX31785) { if (!strcmp("max31785a", id->name)) dev_warn(dev, "Expected max3175a, found max31785: cannot provide secondary tachometer readings\n"); } else { + dev_err(dev, "Unrecognized MAX31785 revision: %x\n", ret); return -ENODEV; } @@ -813,6 +815,7 @@ static int max31785_probe(struct i2c_client *client, static const struct i2c_device_id max31785_id[] = { { "max31785", 0 }, { "max31785a", 0 }, + { "max31785b", 0 }, { }, }; @@ -821,6 +824,7 @@ MODULE_DEVICE_TABLE(i2c, max31785_id); static const struct of_device_id max31785_of_match[] = { { .compatible = "maxim,max31785" }, { .compatible = "maxim,max31785a" }, + { .compatible = "maxim,max31785b" }, { }, };
There was an issue in how the tach feedbacks of dual rotor fans were reported during any change in fan speeds with revision "A" of the MAX31785. When the fan speeds would transition to a new target speed, the rotor not wired to the TACH input when TACHSEL = 0 would report a speed of 0 until the new target was reached. This has been fixed, resulting in a revision "B" update where the MFR_REVISION of "B" is 0x3061. Signed-off-by: Matthew Barth <msbarth@linux.ibm.com> --- drivers/hwmon/pmbus/max31785.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)