diff mbox series

[linux,dev-5.8,v1,3/4] arm: dts: Olympus: Enable PECI dimm temperature

Message ID 20210119223412.223492-4-tmaimon77@gmail.com
State New
Headers show
Series Minor NPCM7xx modifications to dev-5.8 | expand

Commit Message

Tomer Maimon Jan. 19, 2021, 10:34 p.m. UTC
Enable PECI dimm temperature nodes in Olympus
Quanta machine.

Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
 arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts | 2 ++
 1 file changed, 2 insertions(+)

Comments

Joel Stanley Jan. 19, 2021, 10:46 p.m. UTC | #1
On Tue, 19 Jan 2021 at 22:34, Tomer Maimon <tmaimon77@gmail.com> wrote:
>
> Enable PECI dimm temperature nodes in Olympus
> Quanta machine.
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
>  arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts b/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> index 1692bb7314c5..de34c9b2ff2c 100644
> --- a/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> +++ b/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> @@ -910,10 +910,12 @@
>         intel-peci-dimmtemp@30 {
>                 compatible = "intel,peci-client";
>                 reg = <0x30>;
> +               status = "okay";

Nodes are enabled by default, you shouldn't need to add "okay" for it
to work. Can you confirm it works without adding this?


>         };
>         intel-peci-dimmtemp@31 {
>                 compatible = "intel,peci-client";
>                 reg = <0x31>;
> +               status = "okay";
>         };
>  };
>
> --
> 2.22.0
>
Tomer Maimon Jan. 20, 2021, 8:38 a.m. UTC | #2
On Wed, 20 Jan 2021 at 00:47, Joel Stanley <joel@jms.id.au> wrote:

> On Tue, 19 Jan 2021 at 22:34, Tomer Maimon <tmaimon77@gmail.com> wrote:
> >
> > Enable PECI dimm temperature nodes in Olympus
> > Quanta machine.
> >
> > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> > ---
> >  arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> b/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> > index 1692bb7314c5..de34c9b2ff2c 100644
> > --- a/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> > +++ b/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> > @@ -910,10 +910,12 @@
> >         intel-peci-dimmtemp@30 {
> >                 compatible = "intel,peci-client";
> >                 reg = <0x30>;
> > +               status = "okay";
>
> Nodes are enabled by default, you shouldn't need to add "okay" for it
> to work. Can you confirm it works without adding this?
>
> Yes you right.

is working fine without "okay"


>
> >         };
> >         intel-peci-dimmtemp@31 {
> >                 compatible = "intel,peci-client";
> >                 reg = <0x31>;
> > +               status = "okay";
> >         };
> >  };
> >
> > --
> > 2.22.0
> >
>

Cheers,

Tomer
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts b/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
index 1692bb7314c5..de34c9b2ff2c 100644
--- a/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
+++ b/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
@@ -910,10 +910,12 @@ 
 	intel-peci-dimmtemp@30 {
 		compatible = "intel,peci-client";
 		reg = <0x30>;
+		status = "okay";
 	};
 	intel-peci-dimmtemp@31 {
 		compatible = "intel,peci-client";
 		reg = <0x31>;
+		status = "okay";
 	};
 };