diff mbox series

[v2,1/2] dt-bindings: vendor-prefixes: Add an entry for AmpereComputing.com

Message ID 20201130081733.18893-2-quan@os.amperecomputing.com
State New
Headers show
Series ARM: dts: aspeed: Add Ampere Mt. Jade BMC device | expand

Commit Message

Quan Nguyen Nov. 30, 2020, 8:17 a.m. UTC 
Add "ampere" entry for Ampere Computing LLC: amperecomputing.com

Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
Signed-off-by: Phong Vo <phong@os.amperecomputing.com>
Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Andrew Jeffery Dec. 1, 2020, 1:14 a.m. UTC | #1 
On Mon, 30 Nov 2020, at 18:47, Quan Nguyen wrote:
> Add "ampere" entry for Ampere Computing LLC: amperecomputing.com
> 
> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> Signed-off-by: Phong Vo <phong@os.amperecomputing.com>
> Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml 
> b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 604166ecaefb..10f12e98762f 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -85,6 +85,8 @@ patternProperties:
>      description: Shenzhen Amediatech Technology Co., Ltd
>    "^amlogic,.*":
>      description: Amlogic, Inc.
> +  "^ampere,.*":
> +    description: Ampere Computing LLC

This looks okay to me, but it should go upstream.

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Quan Nguyen Dec. 2, 2020, 3:52 a.m. UTC | #2 
Thanks Andrew,
I will sent this patch to upstream.

And I'm wonder if you could ack' ed and merged the DTS patch in this series ?
Or if you have any comment.

Thank you,
-Quan

On Mon, 30 Nov 2020, at 18:47, Quan Nguyen wrote:
> Add "ampere" entry for Ampere Computing LLC: amperecomputing.com
> 
> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> Signed-off-by: Phong Vo <phong@os.amperecomputing.com>
> Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml 
> b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 604166ecaefb..10f12e98762f 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -85,6 +85,8 @@ patternProperties:
>      description: Shenzhen Amediatech Technology Co., Ltd
>    "^amlogic,.*":
>      description: Amlogic, Inc.
> +  "^ampere,.*":
> +    description: Ampere Computing LLC

This looks okay to me, but it should go upstream.

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Joel Stanley Dec. 8, 2020, 2:54 a.m. UTC | #3 
On Tue, 1 Dec 2020 at 01:14, Andrew Jeffery <andrew@aj.id.au> wrote:
>
>
>
> On Mon, 30 Nov 2020, at 18:47, Quan Nguyen wrote:
> > Add "ampere" entry for Ampere Computing LLC: amperecomputing.com
> >
> > Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> > Signed-off-by: Phong Vo <phong@os.amperecomputing.com>
> > Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com>
> > ---
> >  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > index 604166ecaefb..10f12e98762f 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -85,6 +85,8 @@ patternProperties:
> >      description: Shenzhen Amediatech Technology Co., Ltd
> >    "^amlogic,.*":
> >      description: Amlogic, Inc.
> > +  "^ampere,.*":
> > +    description: Ampere Computing LLC
>
> This looks okay to me, but it should go upstream.

+100 :)

Please send both of these upstream using get_maintainers.pl. You can
(should) include the Reviewed-by tags from Andrew and myself.


>
> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>

Reviewed-by: Joel Stanley <joel@jms.id.au>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 604166ecaefb..10f12e98762f 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -85,6 +85,8 @@  patternProperties:
     description: Shenzhen Amediatech Technology Co., Ltd
   "^amlogic,.*":
     description: Amlogic, Inc.
+  "^ampere,.*":
+    description: Ampere Computing LLC
   "^ampire,.*":
     description: Ampire Co., Ltd.
   "^ams,.*":