| Message ID | 20190919152340.23133-7-bradleyb@fuzziesquirrel.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v2,linux,dev-5.3,1/4] dt-bindings: lpc: add aspeed-g6 compatible strings | expand |
On 9/19/19 10:23 AM, Brad Bishop wrote: > Assume The AST2600 SoCs contain the same LPC devices as the AST2500. Reviewed-by: Eddie James <eajames@linux.ibm.com> > > Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> > --- > .../devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt | 3 ++- > Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 8 +++++++- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt > index 028268fd99ee..4b43b7829bd9 100644 > --- a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt > +++ b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt > @@ -1,6 +1,6 @@ > * Aspeed BT (Block Transfer) IPMI interface > > -The Aspeed SOCs (AST2400 and AST2500) are commonly used as BMCs > +The Aspeed SOCs (AST2400, AST2500 and AST2600) are commonly used as BMCs > (BaseBoard Management Controllers) and the BT interface can be used to > perform in-band IPMI communication with their host. > > @@ -9,6 +9,7 @@ Required properties: > - compatible : should be one of > "aspeed,ast2400-ibt-bmc" > "aspeed,ast2500-ibt-bmc" > + "aspeed,ast2600-ibt-bmc" > - reg: physical address and size of the registers > > Optional properties: > diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > index 86446074e206..e1197bab57bb 100644 > --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > @@ -46,6 +46,7 @@ Required properties > - compatible: One of: > "aspeed,ast2400-lpc", "simple-mfd" > "aspeed,ast2500-lpc", "simple-mfd" > + "aspeed,ast2600-lpc", "simple-mfd" > > - reg: contains the physical address and length values of the Aspeed > LPC memory region. > @@ -64,6 +65,7 @@ BMC Node > - compatible: One of: > "aspeed,ast2400-lpc-bmc" > "aspeed,ast2500-lpc-bmc" > + "aspeed,ast2600-lpc-bmc" > > - reg: contains the physical address and length values of the > H8S/2168-compatible LPC controller memory region > @@ -74,6 +76,7 @@ Host Node > - compatible: One of: > "aspeed,ast2400-lpc-host", "simple-mfd", "syscon" > "aspeed,ast2500-lpc-host", "simple-mfd", "syscon" > + "aspeed,ast2600-lpc-host", "simple-mfd", "syscon" > > - reg: contains the address and length values of the host-related > register space for the Aspeed LPC controller > @@ -128,6 +131,7 @@ Required properties: > - compatible: One of: > "aspeed,ast2400-lpc-ctrl"; > "aspeed,ast2500-lpc-ctrl"; > + "aspeed,ast2600-lpc-ctrl"; > > - reg: contains offset/length values of the host interface controller > memory regions > @@ -168,6 +172,7 @@ Required properties: > - compatible: One of: > "aspeed,ast2400-lhc"; > "aspeed,ast2500-lhc"; > + "aspeed,ast2600-lhc"; > > - reg: contains offset/length values of the LHC memory regions. In the > AST2400 and AST2500 there are two regions. > @@ -187,7 +192,8 @@ state of the LPC bus. Some systems may chose to modify this configuration. > > Required properties: > > - - compatible: "aspeed,ast2500-lpc-reset" or > + - compatible: "aspeed,ast2600-lpc-reset" or > + "aspeed,ast2500-lpc-reset" > "aspeed,ast2400-lpc-reset" > - reg: offset and length of the IP in the LHC memory region > - #reset-controller indicates the number of reset cells expected
On Fri, 20 Sep 2019, at 01:55, Eddie James wrote: > > On 9/19/19 10:23 AM, Brad Bishop wrote: > > Assume The AST2600 SoCs contain the same LPC devices as the AST2500. Has anyone validated the assumption? > > > Reviewed-by: Eddie James <eajames@linux.ibm.com> > > > > > > Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> > > --- > > .../devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt | 3 ++- > > Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 8 +++++++- This should be split in two for upstream as the IPMI changes will need to go via Corey while the MFD changes go through Lee. Otherwise, it's fine in principle. Andrew > > 2 files changed, 9 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt > > index 028268fd99ee..4b43b7829bd9 100644 > > --- a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt > > +++ b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt > > @@ -1,6 +1,6 @@ > > * Aspeed BT (Block Transfer) IPMI interface > > > > -The Aspeed SOCs (AST2400 and AST2500) are commonly used as BMCs > > +The Aspeed SOCs (AST2400, AST2500 and AST2600) are commonly used as BMCs > > (BaseBoard Management Controllers) and the BT interface can be used to > > perform in-band IPMI communication with their host. > > > > @@ -9,6 +9,7 @@ Required properties: > > - compatible : should be one of > > "aspeed,ast2400-ibt-bmc" > > "aspeed,ast2500-ibt-bmc" > > + "aspeed,ast2600-ibt-bmc" > > - reg: physical address and size of the registers > > > > Optional properties: > > diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > > index 86446074e206..e1197bab57bb 100644 > > --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > > +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > > @@ -46,6 +46,7 @@ Required properties > > - compatible: One of: > > "aspeed,ast2400-lpc", "simple-mfd" > > "aspeed,ast2500-lpc", "simple-mfd" > > + "aspeed,ast2600-lpc", "simple-mfd" > > > > - reg: contains the physical address and length values of the Aspeed > > LPC memory region. > > @@ -64,6 +65,7 @@ BMC Node > > - compatible: One of: > > "aspeed,ast2400-lpc-bmc" > > "aspeed,ast2500-lpc-bmc" > > + "aspeed,ast2600-lpc-bmc" > > > > - reg: contains the physical address and length values of the > > H8S/2168-compatible LPC controller memory region > > @@ -74,6 +76,7 @@ Host Node > > - compatible: One of: > > "aspeed,ast2400-lpc-host", "simple-mfd", "syscon" > > "aspeed,ast2500-lpc-host", "simple-mfd", "syscon" > > + "aspeed,ast2600-lpc-host", "simple-mfd", "syscon" > > > > - reg: contains the address and length values of the host-related > > register space for the Aspeed LPC controller > > @@ -128,6 +131,7 @@ Required properties: > > - compatible: One of: > > "aspeed,ast2400-lpc-ctrl"; > > "aspeed,ast2500-lpc-ctrl"; > > + "aspeed,ast2600-lpc-ctrl"; > > > > - reg: contains offset/length values of the host interface controller > > memory regions > > @@ -168,6 +172,7 @@ Required properties: > > - compatible: One of: > > "aspeed,ast2400-lhc"; > > "aspeed,ast2500-lhc"; > > + "aspeed,ast2600-lhc"; > > > > - reg: contains offset/length values of the LHC memory regions. In the > > AST2400 and AST2500 there are two regions. > > @@ -187,7 +192,8 @@ state of the LPC bus. Some systems may chose to modify this configuration. > > > > Required properties: > > > > - - compatible: "aspeed,ast2500-lpc-reset" or > > + - compatible: "aspeed,ast2600-lpc-reset" or > > + "aspeed,ast2500-lpc-reset" > > "aspeed,ast2400-lpc-reset" > > - reg: offset and length of the IP in the LHC memory region > > - #reset-controller indicates the number of reset cells expected >
at 2:30 AM, Andrew Jeffery <andrew@aj.id.au> wrote: Thanks Andrew, Eddie for the review. > > > On Fri, 20 Sep 2019, at 01:55, Eddie James wrote: >> On 9/19/19 10:23 AM, Brad Bishop wrote: >>> Assume The AST2600 SoCs contain the same LPC devices as the AST2500. > > Has anyone validated the assumption? They have the same register set in the LPC space. This is about as far as I’ve gotten. > >> Reviewed-by: Eddie James <eajames@linux.ibm.com> >> >> >>> Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> >>> --- >>> .../devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt | 3 ++- >>> Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 8 +++++++- > > This should be split in two for upstream as the IPMI changes will need to > go > via Corey while the MFD changes go through Lee. Split in two in v3.
diff --git a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt index 028268fd99ee..4b43b7829bd9 100644 --- a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt +++ b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt @@ -1,6 +1,6 @@ * Aspeed BT (Block Transfer) IPMI interface -The Aspeed SOCs (AST2400 and AST2500) are commonly used as BMCs +The Aspeed SOCs (AST2400, AST2500 and AST2600) are commonly used as BMCs (BaseBoard Management Controllers) and the BT interface can be used to perform in-band IPMI communication with their host. @@ -9,6 +9,7 @@ Required properties: - compatible : should be one of "aspeed,ast2400-ibt-bmc" "aspeed,ast2500-ibt-bmc" + "aspeed,ast2600-ibt-bmc" - reg: physical address and size of the registers Optional properties: diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt index 86446074e206..e1197bab57bb 100644 --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt @@ -46,6 +46,7 @@ Required properties - compatible: One of: "aspeed,ast2400-lpc", "simple-mfd" "aspeed,ast2500-lpc", "simple-mfd" + "aspeed,ast2600-lpc", "simple-mfd" - reg: contains the physical address and length values of the Aspeed LPC memory region. @@ -64,6 +65,7 @@ BMC Node - compatible: One of: "aspeed,ast2400-lpc-bmc" "aspeed,ast2500-lpc-bmc" + "aspeed,ast2600-lpc-bmc" - reg: contains the physical address and length values of the H8S/2168-compatible LPC controller memory region @@ -74,6 +76,7 @@ Host Node - compatible: One of: "aspeed,ast2400-lpc-host", "simple-mfd", "syscon" "aspeed,ast2500-lpc-host", "simple-mfd", "syscon" + "aspeed,ast2600-lpc-host", "simple-mfd", "syscon" - reg: contains the address and length values of the host-related register space for the Aspeed LPC controller @@ -128,6 +131,7 @@ Required properties: - compatible: One of: "aspeed,ast2400-lpc-ctrl"; "aspeed,ast2500-lpc-ctrl"; + "aspeed,ast2600-lpc-ctrl"; - reg: contains offset/length values of the host interface controller memory regions @@ -168,6 +172,7 @@ Required properties: - compatible: One of: "aspeed,ast2400-lhc"; "aspeed,ast2500-lhc"; + "aspeed,ast2600-lhc"; - reg: contains offset/length values of the LHC memory regions. In the AST2400 and AST2500 there are two regions. @@ -187,7 +192,8 @@ state of the LPC bus. Some systems may chose to modify this configuration. Required properties: - - compatible: "aspeed,ast2500-lpc-reset" or + - compatible: "aspeed,ast2600-lpc-reset" or + "aspeed,ast2500-lpc-reset" "aspeed,ast2400-lpc-reset" - reg: offset and length of the IP in the LHC memory region - #reset-controller indicates the number of reset cells expected
Assume The AST2600 SoCs contain the same LPC devices as the AST2500. Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> --- .../devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt | 3 ++- Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 8 +++++++- 2 files changed, 9 insertions(+), 2 deletions(-)