| Message ID | 20170112021328.27200-2-raltherr@google.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
Hi Rick, On Thu, Jan 12, 2017 at 1:13 PM, Rick Altherr <raltherr@google.com> wrote: > HUSH is the newer command-line interface that provides scripting > capabilities. Those are needed for an boot command that can boot either > a FIT image that includes a ramdisk or a separate kernel and ramdisk. For some reason this patch didn't arrive in my mailbox. I found it on patchwork. I took at look at the code size change with enabling this: $ size u-boot && ls -la u-boot.bin text data bss dec hex filename 215567 7152 71048 293767 47b87 u-boot -rw-r--r-- 1 joel joel 222536 Dec 8 12:03 u-boot.bin $ size u-boot && ls -la u-boot.bin text data bss dec hex filename 227643 7448 71448 306539 4ad6b u-boot -rw-r--r-- 1 joel joel 234908 Jan 16 08:30 u-boot.bin We go up by 5.6%, or 12KB. We're still well within the 384KB partition size, so there is no issue there. I've merged it into our u-boot tree. Cheers, Joel > Signed-off-by: Rick Altherr <raltherr@google.com> > --- > > configs/ast_g4_ncsi_defconfig | 1 + > configs/ast_g4_phy_defconfig | 1 + > configs/ast_g5_ncsi_defconfig | 1 + > configs/ast_g5_phy_defconfig | 1 + > 4 files changed, 4 insertions(+) > > diff --git a/configs/ast_g4_ncsi_defconfig b/configs/ast_g4_ncsi_defconfig > index ab4907cfe2..54686bee5c 100644 > --- a/configs/ast_g4_ncsi_defconfig > +++ b/configs/ast_g4_ncsi_defconfig > @@ -7,6 +7,7 @@ CONFIG_CMD_PING=y > CONFIG_EFI_LOADER=n > CONFIG_FIT=y > CONFIG_FIT_VERBOSE=y > +CONFIG_HUSH_PARSER=y > CONFIG_OF_LIBFDT=y > CONFIG_SPI_FLASH=y > CONFIG_SYS_NS16550=y > diff --git a/configs/ast_g4_phy_defconfig b/configs/ast_g4_phy_defconfig > index 21a56c4b96..f8db39ef13 100644 > --- a/configs/ast_g4_phy_defconfig > +++ b/configs/ast_g4_phy_defconfig > @@ -8,6 +8,7 @@ CONFIG_CMD_PING=y > CONFIG_EFI_LOADER=n > CONFIG_FIT=y > CONFIG_FIT_VERBOSE=y > +CONFIG_HUSH_PARSER=y > CONFIG_OF_LIBFDT=y > CONFIG_SPI_FLASH=y > CONFIG_SYS_NS16550=y > diff --git a/configs/ast_g5_ncsi_defconfig b/configs/ast_g5_ncsi_defconfig > index 7cd4fd116d..74029ed514 100644 > --- a/configs/ast_g5_ncsi_defconfig > +++ b/configs/ast_g5_ncsi_defconfig > @@ -7,6 +7,7 @@ CONFIG_CMD_PING=y > CONFIG_EFI_LOADER=n > CONFIG_FIT=y > CONFIG_FIT_VERBOSE=y > +CONFIG_HUSH_PARSER=y > CONFIG_OF_LIBFDT=y > CONFIG_SPI_FLASH=y > CONFIG_SYS_NS16550=y > diff --git a/configs/ast_g5_phy_defconfig b/configs/ast_g5_phy_defconfig > index c686dd2297..767f3af605 100644 > --- a/configs/ast_g5_phy_defconfig > +++ b/configs/ast_g5_phy_defconfig > @@ -8,6 +8,7 @@ CONFIG_CMD_PING=y > CONFIG_EFI_LOADER=n > CONFIG_FIT=y > CONFIG_FIT_VERBOSE=y > +CONFIG_HUSH_PARSER=y > CONFIG_OF_LIBFDT=y > CONFIG_SPI_FLASH=y > CONFIG_SYS_NS16550=y
diff --git a/configs/ast_g4_ncsi_defconfig b/configs/ast_g4_ncsi_defconfig index ab4907cfe2..54686bee5c 100644 --- a/configs/ast_g4_ncsi_defconfig +++ b/configs/ast_g4_ncsi_defconfig @@ -7,6 +7,7 @@ CONFIG_CMD_PING=y CONFIG_EFI_LOADER=n CONFIG_FIT=y CONFIG_FIT_VERBOSE=y +CONFIG_HUSH_PARSER=y CONFIG_OF_LIBFDT=y CONFIG_SPI_FLASH=y CONFIG_SYS_NS16550=y diff --git a/configs/ast_g4_phy_defconfig b/configs/ast_g4_phy_defconfig index 21a56c4b96..f8db39ef13 100644 --- a/configs/ast_g4_phy_defconfig +++ b/configs/ast_g4_phy_defconfig @@ -8,6 +8,7 @@ CONFIG_CMD_PING=y CONFIG_EFI_LOADER=n CONFIG_FIT=y CONFIG_FIT_VERBOSE=y +CONFIG_HUSH_PARSER=y CONFIG_OF_LIBFDT=y CONFIG_SPI_FLASH=y CONFIG_SYS_NS16550=y diff --git a/configs/ast_g5_ncsi_defconfig b/configs/ast_g5_ncsi_defconfig index 7cd4fd116d..74029ed514 100644 --- a/configs/ast_g5_ncsi_defconfig +++ b/configs/ast_g5_ncsi_defconfig @@ -7,6 +7,7 @@ CONFIG_CMD_PING=y CONFIG_EFI_LOADER=n CONFIG_FIT=y CONFIG_FIT_VERBOSE=y +CONFIG_HUSH_PARSER=y CONFIG_OF_LIBFDT=y CONFIG_SPI_FLASH=y CONFIG_SYS_NS16550=y diff --git a/configs/ast_g5_phy_defconfig b/configs/ast_g5_phy_defconfig index c686dd2297..767f3af605 100644 --- a/configs/ast_g5_phy_defconfig +++ b/configs/ast_g5_phy_defconfig @@ -8,6 +8,7 @@ CONFIG_CMD_PING=y CONFIG_EFI_LOADER=n CONFIG_FIT=y CONFIG_FIT_VERBOSE=y +CONFIG_HUSH_PARSER=y CONFIG_OF_LIBFDT=y CONFIG_SPI_FLASH=y CONFIG_SYS_NS16550=y
HUSH is the newer command-line interface that provides scripting capabilities. Those are needed for an boot command that can boot either a FIT image that includes a ramdisk or a separate kernel and ramdisk. Signed-off-by: Rick Altherr <raltherr@google.com> --- configs/ast_g4_ncsi_defconfig | 1 + configs/ast_g4_phy_defconfig | 1 + configs/ast_g5_ncsi_defconfig | 1 + configs/ast_g5_phy_defconfig | 1 + 4 files changed, 4 insertions(+)