mbox series

[linux,dev-6.6,0/1] hwmon: Add driver for Astera Labs PT5161L retimer

Message ID 20240822094803.2849010-1-chou.cosmo@gmail.com
Headers show
Series hwmon: Add driver for Astera Labs PT5161L retimer | expand

Message

Cosmo Chou Aug. 22, 2024, 9:48 a.m. UTC 
This driver implements support for temperature monitoring of Astera Labs
PT5161L series PCIe retimer chips.

LINK: [v1] https://lore.kernel.org/all/20231205074723.3546295-1-chou.cosmo@gmail.com/

v6:
  - Remove unnecessary return value checking
  - Correct the available size for simple_read_from_buffer()

v5:
  - Fix warning and check messages of 'checkpatch --strict'
  - Without resubmitting the applied patches

v4:
  - Rebased

v3:
  - Revise pt5161l.rst
  - Revise the style of comments
  - Remove unused pec_enable
  - Add back safe access wide registers
  - fix build warning

v2:
  - Add "asteralabs,pt5161l" to trivial-devices.yaml
  - Change naming PT516XX/pt516xx to PT5161L/pt5161l
  - Separated debugfs files for health status
  - Revise the style of comments
  - Remove unused defines
  - Remove including unused header files
  - Remove unnecessary debugging messages
  - Revise the data parsing for a big-endian system
  - Use read_block_data instead of accessing wide registers
  - Remove the debugfs files when the device is unloaded
  - Add acpi_match_table

Cosmo Chou (1):
  hwmon: Add driver for Astera Labs PT5161L retimer

 Documentation/hwmon/index.rst   |   1 +
 Documentation/hwmon/pt5161l.rst |  42 ++
 MAINTAINERS                     |   7 +
 drivers/hwmon/Kconfig           |  10 +
 drivers/hwmon/Makefile          |   1 +
 drivers/hwmon/pt5161l.c         | 667 ++++++++++++++++++++++++++++++++
 6 files changed, 728 insertions(+)
 create mode 100644 Documentation/hwmon/pt5161l.rst
 create mode 100644 drivers/hwmon/pt5161l.c

Comments

Andrew Jeffery Aug. 23, 2024, 3:46 a.m. UTC | #1 
Hi Cosmo,

On Thu, 2024-08-22 at 17:48 +0800, Cosmo Chou wrote:
> This driver implements support for temperature monitoring of Astera Labs
> PT5161L series PCIe retimer chips.
> 
> LINK: [v1] https://lore.kernel.org/all/20231205074723.3546295-1-chou.cosmo@gmail.com/

Thanks for the link. However, I have a few concerns as a result:

- Why have you only sent the one patch in this series? What about the
other two?

- Does what you've sent here address the feedback from Guenter? If not,
can you please continue to work upstream? I'd prefer to backport merged
patches unless there's some critical reason why we must apply something
immediately.

Andrew