| Message ID | 20220129115228.2257310-1-j.neuschaefer@gmx.net |
|---|---|
| Headers | show |
| Series | Nuvoton WPCM450 pinctrl and GPIO driver | expand |
On Sat, Jan 29, 2022 at 12:57 PM Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > This is version 5 of the WPCM450 pinctrl/GPIO driver patchset. I haven't had time to look in detail but the kernel robot is complaining about patch 5... > I was originally just going to rebase the patchset on top of v5.17-rc1, > but while testing, I found that the IRQ handling code violated locking > rules, specifically that it used spin locks (which can sleep on RT kernels) > in IRQ contexts. So I made a few changes to fix that, mainly switching > to raw spin locks. Which patches do you expect to be applied to the pin control tree? Yours, Linus Walleij
On Sun, Jan 30, 2022 at 02:50:25AM +0100, Linus Walleij wrote: > On Sat, Jan 29, 2022 at 12:57 PM Jonathan Neuschäfer > <j.neuschaefer@gmx.net> wrote: > > > This is version 5 of the WPCM450 pinctrl/GPIO driver patchset. > > I haven't had time to look in detail but the kernel robot is complaining > about patch 5... These are warnings about the pinctrl-npcm7xx driver that became (more easily) visible under CONFIG_COMPILE_TEST through my patch. > > > I was originally just going to rebase the patchset on top of v5.17-rc1, > > but while testing, I found that the IRQ handling code violated locking > > rules, specifically that it used spin locks (which can sleep on RT kernels) > > in IRQ contexts. So I made a few changes to fix that, mainly switching > > to raw spin locks. > > Which patches do you expect to be applied to the pin control tree? These two: [PATCH v5 4/9] dt-bindings: pinctrl: Add Nuvoton WPCM450 [PATCH v5 5/9] pinctrl: nuvoton: Add driver for WPCM450 and the rest can go through Joel Stanley's BMC tree, I think. Thanks, Jonathan
On Tue, 1 Feb 2022 at 13:05, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > > On Sun, Jan 30, 2022 at 02:50:25AM +0100, Linus Walleij wrote: > > On Sat, Jan 29, 2022 at 12:57 PM Jonathan Neuschäfer > > <j.neuschaefer@gmx.net> wrote: > > > > > This is version 5 of the WPCM450 pinctrl/GPIO driver patchset. > > Which patches do you expect to be applied to the pin control tree? > > These two: > > [PATCH v5 4/9] dt-bindings: pinctrl: Add Nuvoton WPCM450 > [PATCH v5 5/9] pinctrl: nuvoton: Add driver for WPCM450 > > and the rest can go through Joel Stanley's BMC tree, I think. Seems reasonable. I assume you're sending a v6 to fix some of the warnings? Cheers, Joel
On Tue, Feb 01, 2022 at 11:42:11PM +0000, Joel Stanley wrote: > On Tue, 1 Feb 2022 at 13:05, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > > > > On Sun, Jan 30, 2022 at 02:50:25AM +0100, Linus Walleij wrote: > > > On Sat, Jan 29, 2022 at 12:57 PM Jonathan Neuschäfer > > > <j.neuschaefer@gmx.net> wrote: > > > > > > > This is version 5 of the WPCM450 pinctrl/GPIO driver patchset. > > > > Which patches do you expect to be applied to the pin control tree? > > > > These two: > > > > [PATCH v5 4/9] dt-bindings: pinctrl: Add Nuvoton WPCM450 > > [PATCH v5 5/9] pinctrl: nuvoton: Add driver for WPCM450 > > > > and the rest can go through Joel Stanley's BMC tree, I think. > > Seems reasonable. I assume you're sending a v6 to fix some of the warnings? No, the warnings are fairly independent of this patchset, it's just that the adjacent pinctrl-npcm7xx driver started to be built by the bot, due to my Kconfig change. I'll fix them in a separate patchset. Jonathan
On Wed, Feb 2, 2022 at 2:01 PM Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > On Tue, Feb 01, 2022 at 11:42:11PM +0000, Joel Stanley wrote: > > On Tue, 1 Feb 2022 at 13:05, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: ... > > I assume you're sending a v6 to fix some of the warnings? > > No, the warnings are fairly independent of this patchset, it's just that > the adjacent pinctrl-npcm7xx driver started to be built by the bot, due > to my Kconfig change. I'll fix them in a separate patchset. I guess you need to fix that first. Because now and then all CIs will complain to your patch and confuse people.
On Wed, Feb 02, 2022 at 02:10:44PM +0200, Andy Shevchenko wrote: > On Wed, Feb 2, 2022 at 2:01 PM Jonathan Neuschäfer > <j.neuschaefer@gmx.net> wrote: > > On Tue, Feb 01, 2022 at 11:42:11PM +0000, Joel Stanley wrote: > > > On Tue, 1 Feb 2022 at 13:05, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > > ... > > > > I assume you're sending a v6 to fix some of the warnings? > > > > No, the warnings are fairly independent of this patchset, it's just that > > the adjacent pinctrl-npcm7xx driver started to be built by the bot, due > > to my Kconfig change. I'll fix them in a separate patchset. > > I guess you need to fix that first. > > Because now and then all CIs will complain to your patch and confuse people. Hm, right. I'll send the pinctrl-npcm7xx fixes, and then a version 6 of this patchset if necessary. Jonathan
On Wed, Feb 02, 2022 at 02:10:44PM +0200, Andy Shevchenko wrote: > On Wed, Feb 2, 2022 at 2:01 PM Jonathan Neuschäfer > <j.neuschaefer@gmx.net> wrote: > > On Tue, Feb 01, 2022 at 11:42:11PM +0000, Joel Stanley wrote: > > > On Tue, 1 Feb 2022 at 13:05, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > > ... > > > > I assume you're sending a v6 to fix some of the warnings? > > > > No, the warnings are fairly independent of this patchset, it's just that > > the adjacent pinctrl-npcm7xx driver started to be built by the bot, due > > to my Kconfig change. I'll fix them in a separate patchset. > > I guess you need to fix that first. > > Because now and then all CIs will complain to your patch and confuse people. FWIW, Linus has applied the npcm7xx fixes to for-next in the pinctrl tree, which means that they are not blocking this patchset anymore, AFAICS. Jonathan
On Mon, 14 Feb 2022 at 12:05, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > > On Wed, Feb 02, 2022 at 02:10:44PM +0200, Andy Shevchenko wrote: > > On Wed, Feb 2, 2022 at 2:01 PM Jonathan Neuschäfer > > <j.neuschaefer@gmx.net> wrote: > > > On Tue, Feb 01, 2022 at 11:42:11PM +0000, Joel Stanley wrote: > > > > On Tue, 1 Feb 2022 at 13:05, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > > > > ... > > > > > > I assume you're sending a v6 to fix some of the warnings? > > > > > > No, the warnings are fairly independent of this patchset, it's just that > > > the adjacent pinctrl-npcm7xx driver started to be built by the bot, due > > > to my Kconfig change. I'll fix them in a separate patchset. > > > > I guess you need to fix that first. > > > > Because now and then all CIs will complain to your patch and confuse people. > > FWIW, Linus has applied the npcm7xx fixes to for-next in the pinctrl tree, > which means that they are not blocking this patchset anymore, AFAICS. I've applied the device tree changes, and I will send a pull request for v5.18 with those. I assume you want Linus to merge the pinctrl bindings and driver through his tree. Cheers, Joel
On Tue, Feb 15, 2022 at 05:56:17AM +0000, Joel Stanley wrote: > On Mon, 14 Feb 2022 at 12:05, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > > > > On Wed, Feb 02, 2022 at 02:10:44PM +0200, Andy Shevchenko wrote: > > > On Wed, Feb 2, 2022 at 2:01 PM Jonathan Neuschäfer > > > <j.neuschaefer@gmx.net> wrote: > > > > On Tue, Feb 01, 2022 at 11:42:11PM +0000, Joel Stanley wrote: > > > > > On Tue, 1 Feb 2022 at 13:05, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > > > > > > ... > > > > > > > > I assume you're sending a v6 to fix some of the warnings? > > > > > > > > No, the warnings are fairly independent of this patchset, it's just that > > > > the adjacent pinctrl-npcm7xx driver started to be built by the bot, due > > > > to my Kconfig change. I'll fix them in a separate patchset. > > > > > > I guess you need to fix that first. > > > > > > Because now and then all CIs will complain to your patch and confuse people. > > > > FWIW, Linus has applied the npcm7xx fixes to for-next in the pinctrl tree, > > which means that they are not blocking this patchset anymore, AFAICS. > > I've applied the device tree changes, and I will send a pull request > for v5.18 with those. Thanks! > I assume you want Linus to merge the pinctrl bindings and driver > through his tree. Yes, that sounds alright. Jonathan
On Sat, Jan 29, 2022 at 12:57 PM Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > dt-bindings: pinctrl: Add Nuvoton WPCM450 > pinctrl: nuvoton: Add driver for WPCM450 I applied these two to the pinctrl tree. Sorry for taking forever to figure out that I needed to do this :/ Yours, Linus Walleij
On Tue, 15 Mar 2022 at 00:17, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Sat, Jan 29, 2022 at 12:57 PM Jonathan Neuschäfer > <j.neuschaefer@gmx.net> wrote: > > > dt-bindings: pinctrl: Add Nuvoton WPCM450 > > pinctrl: nuvoton: Add driver for WPCM450 > > I applied these two to the pinctrl tree. Sorry for taking forever > to figure out that I needed to do this :/ Thanks Linus. The device tree changes are queued for v5.18 too, so they will all go in at the same time. Cheers, Joel