diff mbox

[13/17] libgcrypt: USE-flag defined for conf option --without-capabilities

Message ID 87vc0zgfqn.fsf@xpc.ulstruplund.dk
State Accepted
Delegated to: Esben Haabendal
Headers show

Commit Message

Esben Haabendal Oct. 15, 2013, 7:22 a.m. UTC 
Kim Bøndergaard <kibo@prevas.dk> writes:

> ---
>  recipes/libgcrypt/libgcrypt.inc | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/recipes/libgcrypt/libgcrypt.inc b/recipes/libgcrypt/libgcrypt.inc
> index 01634f6..6befa72 100644
> --- a/recipes/libgcrypt/libgcrypt.inc
> +++ b/recipes/libgcrypt/libgcrypt.inc
> @@ -8,7 +8,11 @@ DEPENDS_${PN} += "libgpg-error libcap2"
>  
>  SRC_URI = "ftp://ftp.gnupg.org/gcrypt/libgcrypt/libgcrypt-${PV}.tar.gz"
>  
> -EXTRA_OECONF = "--without-pth --disable-asm --with-capabilities"
> +RECIPE_FLAGS = "gcrypt_no_capabilities"
> +DEFAULT_gcrypt_no_capabilites = "0"
> +
> +EXTRA_OECONF = "--without-pth --disable-asm"
> +EXTRA_OECONF:>USE_gcrypt_no_capabilities = " --without-capabilities"

According to "./configure --help":

  --with-capabilities     Use linux capabilities default=no

So, with your change, capabilities will always be disabled.

I have changed the logic (double negation is not always too smart), and
flag naming, creating a USE_libgcrypt_capabilities flag instead, which
provides --with-capabilities and --without-capabilities arguments as
needed.

>  # libgcrypt.pc is added locally and thus installed here
>  do_install[postfuncs] += "do_install_append"

The new commit is:


commit 25a141a5b922fb47dff736989764208157948dd0
Author: Esben Haabendal <esben.haabendal@prevas.dk>
Date:   Tue Oct 15 09:21:25 2013 +0200

    libgcrypt: Add USE flag for controlling use of linux capabilities
    
    Signed-off-by: Esben Haabendal <esben.haabendal@prevas.dk>



/Esben
diff mbox

Patch

diff --git a/recipes/libgcrypt/libgcrypt.inc b/recipes/libgcrypt/libgcrypt.inc
index 01634f6..7a48cf7 100644
--- a/recipes/libgcrypt/libgcrypt.inc
+++ b/recipes/libgcrypt/libgcrypt.inc
@@ -8,7 +8,12 @@  DEPENDS_${PN} += "libgpg-error libcap2"
 
 SRC_URI = "ftp://ftp.gnupg.org/gcrypt/libgcrypt/libgcrypt-${PV}.tar.gz"
 
-EXTRA_OECONF = "--without-pth --disable-asm --with-capabilities"
+RECIPE_FLAGS = "libgcrypt_capabilities"
+DEFAULT_USE_libgcrypt_capabilities = "1"
+
+EXTRA_OECONF = "--without-pth --disable-asm ${EXTRA_OECONF_CAPABILITIES}"
+EXTRA_OECONF_CAPABILITIES = "--without-capabilities"
+EXTRA_OECONF_CAPABILITIES:USE_libgcrypt_capabilities = "--with-capabilities"
 
 # libgcrypt.pc is added locally and thus installed here
 do_install[postfuncs] += "do_install_append"