| Message ID | 20231103111102.2801624-2-thaller@redhat.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | add infrastructure for unit tests | expand |
On Fri, Nov 03, 2023 at 12:05:43PM +0100, Thomas Haller wrote: > I don't think that having multiple .gitignore files for a small project > like nftables is best. Anyway. The build artifacts like "*.o" will not > only be found under "src/". Move those patterns. > > Signed-off-by: Thomas Haller <thaller@redhat.com> > --- > .gitignore | 7 ++++++- > src/.gitignore | 5 ----- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/.gitignore b/.gitignore > index a62e31f31c6b..51429020ceb6 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -1,6 +1,11 @@ > -# Generated by autoconf/configure/automake > +# Generated by autoconf/configure/automake/make > *.m4 > +*.la > +*.lo > +*.o > +.deps/ > .dirstamp > +.libs/ > Makefile > Makefile.in > stamp-h1 > diff --git a/src/.gitignore b/src/.gitignore > index 2d907425cbb0..f34105c6cda4 100644 > --- a/src/.gitignore > +++ b/src/.gitignore > @@ -1,8 +1,3 @@ > -*.la > -*.lo > -*.o > -.deps/ > -.libs/ Please, move things where they used to be. > nft > parser_bison.c > parser_bison.h > -- > 2.41.0 >
On Fri, 2023-11-03 at 12:30 +0100, Pablo Neira Ayuso wrote: > > Please, move things where they used to be. will do in v2. Thomas
diff --git a/.gitignore b/.gitignore index a62e31f31c6b..51429020ceb6 100644 --- a/.gitignore +++ b/.gitignore @@ -1,6 +1,11 @@ -# Generated by autoconf/configure/automake +# Generated by autoconf/configure/automake/make *.m4 +*.la +*.lo +*.o +.deps/ .dirstamp +.libs/ Makefile Makefile.in stamp-h1 diff --git a/src/.gitignore b/src/.gitignore index 2d907425cbb0..f34105c6cda4 100644 --- a/src/.gitignore +++ b/src/.gitignore @@ -1,8 +1,3 @@ -*.la -*.lo -*.o -.deps/ -.libs/ nft parser_bison.c parser_bison.h
I don't think that having multiple .gitignore files for a small project like nftables is best. Anyway. The build artifacts like "*.o" will not only be found under "src/". Move those patterns. Signed-off-by: Thomas Haller <thaller@redhat.com> --- .gitignore | 7 ++++++- src/.gitignore | 5 ----- 2 files changed, 6 insertions(+), 6 deletions(-)