| Message ID | 20240829154739.16691-1-ubizjak@gmail.com |
|---|---|
| Headers | show |
| Series | netfilter: nf_tables: Fix percpu address space issues in nf_tables_api.c | expand |
Hi, On Thu, Aug 29, 2024 at 05:29:30PM +0200, Uros Bizjak wrote: > Use {ERR_PTR,IS_ERR,PTR_ERR}_PCPU() macros when crossing between generic > and percpu address spaces and add __percpu annotation to *stats pointer > to fix percpu address space issues. IIRC, you submitted patch 1/2 in this series to the mm tree. Let us know if this patch gets upstreamed via MM tree (if mm maintainers are fine with it) or maybe MM maintainers prefer an alternative path for this. Thanks. > NOTE: The patch depends on a patch that introduces *_PCPU() macros [1] > that is on the way to mainline through the mm tree. For convience, the > patch is included in this patch series, so CI tester is able to test > the second patch without compile failures. > > [1] https://lore.kernel.org/lkml/20240818210235.33481-1-ubizjak@gmail.com/ > > The netfilter patch obsoletes patch [2]. > > [2] https://patchwork.ozlabs.org/project/netfilter-devel/patch/20240806102808.804619-1-ubizjak@gmail.com/ > > Cc: Pablo Neira Ayuso <pablo@netfilter.org> > Cc: Jozsef Kadlecsik <kadlec@netfilter.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > > Uros Bizjak (2): > err.h: Add ERR_PTR_PCPU(), PTR_ERR_PCPU() and IS_ERR_PCPU() macros > netfilter: nf_tables: Fix percpu address space issues in > nf_tables_api.c > > include/linux/err.h | 9 +++++++++ > net/netfilter/nf_tables_api.c | 16 ++++++++-------- > 2 files changed, 17 insertions(+), 8 deletions(-) > > -- > 2.42.0 >
On Tue, Sep 3, 2024 at 6:14 PM Pablo Neira Ayuso <pablo@netfilter.org> wrote: > > Hi, > > On Thu, Aug 29, 2024 at 05:29:30PM +0200, Uros Bizjak wrote: > > Use {ERR_PTR,IS_ERR,PTR_ERR}_PCPU() macros when crossing between generic > > and percpu address spaces and add __percpu annotation to *stats pointer > > to fix percpu address space issues. > > IIRC, you submitted patch 1/2 in this series to the mm tree. Yes, patch 1/2 is in this series just for convenience. > Let us know if this patch gets upstreamed via MM tree (if mm > maintainers are fine with it) or maybe MM maintainers prefer an > alternative path for this. The patch is accepted into the MM tree [1]. [1] https://lore.kernel.org/mm-commits/20240820052852.CB380C4AF0B@smtp.kernel.org/ Thanks, Uros. > > Thanks. > > > NOTE: The patch depends on a patch that introduces *_PCPU() macros [1] > > that is on the way to mainline through the mm tree. For convience, the > > patch is included in this patch series, so CI tester is able to test > > the second patch without compile failures. > > > > [1] https://lore.kernel.org/lkml/20240818210235.33481-1-ubizjak@gmail.com/ > > > > The netfilter patch obsoletes patch [2]. > > > > [2] https://patchwork.ozlabs.org/project/netfilter-devel/patch/20240806102808.804619-1-ubizjak@gmail.com/ > > > > Cc: Pablo Neira Ayuso <pablo@netfilter.org> > > Cc: Jozsef Kadlecsik <kadlec@netfilter.org> > > Cc: "David S. Miller" <davem@davemloft.net> > > Cc: Eric Dumazet <edumazet@google.com> > > Cc: Jakub Kicinski <kuba@kernel.org> > > Cc: Paolo Abeni <pabeni@redhat.com> > > > > Uros Bizjak (2): > > err.h: Add ERR_PTR_PCPU(), PTR_ERR_PCPU() and IS_ERR_PCPU() macros > > netfilter: nf_tables: Fix percpu address space issues in > > nf_tables_api.c > > > > include/linux/err.h | 9 +++++++++ > > net/netfilter/nf_tables_api.c | 16 ++++++++-------- > > 2 files changed, 17 insertions(+), 8 deletions(-) > > > > -- > > 2.42.0 > >
On Tue, Sep 03, 2024 at 06:19:57PM +0200, Uros Bizjak wrote: > On Tue, Sep 3, 2024 at 6:14 PM Pablo Neira Ayuso <pablo@netfilter.org> wrote: > > > > Hi, > > > > On Thu, Aug 29, 2024 at 05:29:30PM +0200, Uros Bizjak wrote: > > > Use {ERR_PTR,IS_ERR,PTR_ERR}_PCPU() macros when crossing between generic > > > and percpu address spaces and add __percpu annotation to *stats pointer > > > to fix percpu address space issues. > > > > IIRC, you submitted patch 1/2 in this series to the mm tree. > > Yes, patch 1/2 is in this series just for convenience. > > > Let us know if this patch gets upstreamed via MM tree (if mm > > maintainers are fine with it) or maybe MM maintainers prefer an > > alternative path for this. > > The patch is accepted into the MM tree [1]. > > [1] https://lore.kernel.org/mm-commits/20240820052852.CB380C4AF0B@smtp.kernel.org/ Thanks, I will wait for it to propagate to the netdev tree.
Use {ERR_PTR,IS_ERR,PTR_ERR}_PCPU() macros when crossing between generic and percpu address spaces and add __percpu annotation to *stats pointer to fix percpu address space issues. NOTE: The patch depends on a patch that introduces *_PCPU() macros [1] that is on the way to mainline through the mm tree. For convience, the patch is included in this patch series, so CI tester is able to test the second patch without compile failures. [1] https://lore.kernel.org/lkml/20240818210235.33481-1-ubizjak@gmail.com/ The netfilter patch obsoletes patch [2]. [2] https://patchwork.ozlabs.org/project/netfilter-devel/patch/20240806102808.804619-1-ubizjak@gmail.com/ Cc: Pablo Neira Ayuso <pablo@netfilter.org> Cc: Jozsef Kadlecsik <kadlec@netfilter.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> Uros Bizjak (2): err.h: Add ERR_PTR_PCPU(), PTR_ERR_PCPU() and IS_ERR_PCPU() macros netfilter: nf_tables: Fix percpu address space issues in nf_tables_api.c include/linux/err.h | 9 +++++++++ net/netfilter/nf_tables_api.c | 16 ++++++++-------- 2 files changed, 17 insertions(+), 8 deletions(-)