From patchwork Sat Sep 11 11:12:34 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Schwab X-Patchwork-Id: 64508 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 930A4B6F10 for ; Sat, 11 Sep 2010 21:12:43 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751270Ab0IKLMj (ORCPT ); Sat, 11 Sep 2010 07:12:39 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:49084 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066Ab0IKLMi (ORCPT ); Sat, 11 Sep 2010 07:12:38 -0400 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 302851C15CC9; Sat, 11 Sep 2010 13:12:37 +0200 (CEST) Received: from igel.home (ppp-88-217-106-55.dynamic.mnet-online.de [88.217.106.55]) by mail.mnet-online.de (Postfix) with ESMTP id C1F291C000E9; Sat, 11 Sep 2010 13:12:37 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id F3407CA299; Sat, 11 Sep 2010 13:12:35 +0200 (CEST) From: Andreas Schwab To: Divy Le Ray Subject: [PATCH] net/cxgb3: remove undefined operations CC: netdev@vger.kernel.org X-Yow: I am a jelly donut. I am a jelly donut. Date: Sat, 11 Sep 2010 13:12:34 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Modifying an object twice without an intervening sequence point is undefined. Signed-off-by: Andreas Schwab --- drivers/net/cxgb3/t3_hw.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/cxgb3/t3_hw.c b/drivers/net/cxgb3/t3_hw.c index 427c451..997b14b 100644 --- a/drivers/net/cxgb3/t3_hw.c +++ b/drivers/net/cxgb3/t3_hw.c @@ -3682,7 +3682,7 @@ static void mc7_prep(struct adapter *adapter, struct mc7 *mc7, mc7->name = name; mc7->offset = base_addr - MC7_PMRX_BASE_ADDR; cfg = t3_read_reg(adapter, mc7->offset + A_MC7_CFG); - mc7->size = mc7->size = G_DEN(cfg) == M_DEN ? 0 : mc7_calc_size(cfg); + mc7->size = G_DEN(cfg) == M_DEN ? 0 : mc7_calc_size(cfg); mc7->width = G_WIDTH(cfg); }