From patchwork Fri Mar 9 10:41:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 883557 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pOn0E1fF"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zyP8Z1g9Vz9sdv for ; Fri, 9 Mar 2018 21:42:22 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751001AbeCIKmK (ORCPT ); Fri, 9 Mar 2018 05:42:10 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35115 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800AbeCIKmI (ORCPT ); Fri, 9 Mar 2018 05:42:08 -0500 Received: by mail-pf0-f193.google.com with SMTP id y186so1128295pfb.2; Fri, 09 Mar 2018 02:42:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=sr0uoAIOnSuRkzSsxzXLGrLpnkA8WBJrUL8xWXkKwKU=; b=pOn0E1fFjH9nJPRHi2l/RWhxm21wKtezySh6AcJGJzZXws+6u8PWmgGIKDQpSqo3hG 0+JG1bcm+P6BnUg1QADX65Cbociuy47rGSAoMiDyKE0aef1vMaOVARQmmXNaNPgBcnfl 9STUeFqWV04ESCOtJkQFcaslW/C7oEY8N+g4woAnGjsX1f/ymbyGbd/tBVPsUhCpnJ5X Fj05sb6zOj6eCbimfeJ11vYny15w64yztYQbZkzdGCcOW5xdSlMgLP6Wk9G0lv96mG98 9GW/Il+MYkCanYSncqNZYD9Jr+tR3KX2omwcmm6E7NYk//O6ofF1PcwnEIhLb6EzEQdk rZHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=sr0uoAIOnSuRkzSsxzXLGrLpnkA8WBJrUL8xWXkKwKU=; b=AQhcr+ziPjchysoafh4cAghdzEsmikYWUs7mg8ZUs0pXl4eA9lNBVvvI3gvgKoRReb K8TwzL4OoV7w3udwPrRZcr0drxl91Anp2fQjOgOai3WKb9NUxaBfL2zlgtWrI5DLYcYL jkcBRd2zm9Y77mP5u1Y5Q2mlTC8gY6Gk3L0xTYUoZdEVzx1D3utfxZbXRhgusSsJCVhZ zI2DmXyir6m/rsHRH6gFr7ErMHvb9tlcxwTFYutWfh7BUQV74q3toZrZTv/V0DVRXvV1 00nDBZfcxopVbkxoSbGmCg46V+/9jMb1AS7bHz7Q6R5av61THcf7E0IxK9ExV73VicuN IX5w== X-Gm-Message-State: APf1xPATiXxJ0xvMM+cnv5G7sewKLpuivTw8uHh3+OyP2f5OxdMA9Xmz VPmj77rMGq3W10vvUOqBa8s= X-Google-Smtp-Source: AG47ELs/r+TSW+8ltSHBcRiRfFmWIrOI1c01mpaVW7ucTxs79R7U7/9IKuL9ENHMo0pQn+EiJscqSQ== X-Received: by 10.99.125.19 with SMTP id y19mr23344356pgc.285.1520592128435; Fri, 09 Mar 2018 02:42:08 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([149.23.17.254]) by smtp.googlemail.com with ESMTPSA id h15sm2181278pfi.56.2018.03.09.02.42.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 09 Mar 2018 02:42:07 -0800 (PST) From: Arvind Yadav To: yisen.zhuang@huawei.com, salil.mehta@huawei.com, linyunsheng@huawei.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] net: hns: use put_device() if device_register fail Date: Fri, 9 Mar 2018 16:11:17 +0530 Message-Id: X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/hisilicon/hns/hnae.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.c b/drivers/net/ethernet/hisilicon/hns/hnae.c index a051e58..0cf5ceb 100644 --- a/drivers/net/ethernet/hisilicon/hns/hnae.c +++ b/drivers/net/ethernet/hisilicon/hns/hnae.c @@ -422,8 +422,10 @@ int hnae_ae_register(struct hnae_ae_dev *hdev, struct module *owner) hdev->cls_dev.release = hnae_release; (void)dev_set_name(&hdev->cls_dev, "hnae%d", hdev->id); ret = device_register(&hdev->cls_dev); - if (ret) + if (ret) { + put_device(&hdev->cls_dev); return ret; + } __module_get(THIS_MODULE);