From patchwork Thu Nov 16 04:27:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838407 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ogPSQ0Ew"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpF85jFcz9s7g for ; Thu, 16 Nov 2017 15:30:04 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758936AbdKPE36 (ORCPT ); Wed, 15 Nov 2017 23:29:58 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:56336 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758668AbdKPE3T (ORCPT ); Wed, 15 Nov 2017 23:29:19 -0500 Received: by mail-pg0-f65.google.com with SMTP id z184so14293638pgd.13; Wed, 15 Nov 2017 20:29:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=gIGE11Ld59ADzdaCyZhx5QBSlxIZw3CigOf8BfbvA4Y=; b=ogPSQ0EwGyh2yyYmuiJn0nDoRAgOLtDMMUNIOKHXiPNviLRhg+gfJTaWCqtMV26zMm 2vnvroqOircjMW2Ilkc1QT3bZXF6iArVv0wR5y5azARIJd0HgSvMiIcfme9VF56ntwU9 xPwXgn0thQvRuhDt+SlS3dz4cmSieP/FiVDrRVSUcdMzIkpHCgO6JN0FgOFW4kbGRT9e +RnI+h0cc45Luj72AZWiUxM5i853geRAb3+PjOT7TaSFpfUMkyycFSkomQTgP1QLgUwN 7HxGkkPebGIezHjyZjJAqaoRwueScMxrbu8iKv4QKIL56gHFUTbcK3yuRegJa/iw84mb KsYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=gIGE11Ld59ADzdaCyZhx5QBSlxIZw3CigOf8BfbvA4Y=; b=OQNsktrvuAhfIGDXi1Vca3YpYVoRoKgOLeM5NxKYIxXb/WNLGiU0BfbHG95uspK8au fwr/7xUjX1dKhyKh0EMbJnRqlMBZB5K5zRqNlhV+KrKiYpJ4opfcD7qQVyL9tDNd7vHc P1gfCdUMTooRwR5HJYx8DXIE/HP4NH93OQcr6m+C47My5tyYneBMAAN870ovNclCkv+S Q6IEQJasz/iq0nioe60rttSdqRSyeew+PjiyWqk/KeinndUVt7YGsI95yOj97MFgfcBP WaAfPVkiHJRsk+aa+XEgksEqdW6rNcDcYtjULHfQHcgQoHLJ1nDJ2x/3bX63GWmThVQJ Sdbg== X-Gm-Message-State: AJaThX7Q/39gw/hDhGNQr0XZqIhv6p+u+Z3o/8086rE7t1jPluiwkoVs 3eME7jXG//nPRtTpOwlnr68= X-Google-Smtp-Source: AGs4zMZl2YFXsCgoem4iSW2EzUvAcpnMzOtTZY+wOno4Kq+6d5ObVU8teL4/n8NsmmNJt63nAsFzrg== X-Received: by 10.159.197.67 with SMTP id d3mr385337plo.409.1510806558935; Wed, 15 Nov 2017 20:29:18 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.29.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:29:18 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 10/12] isdn: hisax: Fix pnp_irq's error checking for setup_niccy Date: Thu, 16 Nov 2017 09:57:27 +0530 Message-Id: X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/niccy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/niccy.c b/drivers/isdn/hisax/niccy.c index e4c33cf..dfbcd2e 100644 --- a/drivers/isdn/hisax/niccy.c +++ b/drivers/isdn/hisax/niccy.c @@ -261,7 +261,7 @@ int setup_niccy(struct IsdnCard *card) card->para[1] = pnp_port_start(pnp_d, 0); card->para[2] = pnp_port_start(pnp_d, 1); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1] || + if (card->para[0] == -1 || !card->para[1] || !card->para[2]) { printk(KERN_ERR "NiccyPnP:some resources are " "missing %ld/%lx/%lx\n",