From patchwork Thu Nov 16 04:27:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838405 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ks/RCTVR"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpDj3j5lz9sNc for ; Thu, 16 Nov 2017 15:29:41 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758822AbdKPE3h (ORCPT ); Wed, 15 Nov 2017 23:29:37 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:49771 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758692AbdKPE3G (ORCPT ); Wed, 15 Nov 2017 23:29:06 -0500 Received: by mail-pf0-f196.google.com with SMTP id l24so6280585pfj.6; Wed, 15 Nov 2017 20:29:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=RD4vYSiyGfWfM8+zBSilB1VFrlPVw0KeRxNFGzToHPQ=; b=ks/RCTVR7lLvdQW1b0tEO62pd0VJilHrJJrgUY79mvrz1fDLkyDDdXhHtpFE3sqORg JSoJ1UxYWTXbhf5CHzpms3Ix42a7xEue5nO9pPRh+XuF/F9ZE+ed2dCiCcbX3oVRTckx +eq4epFL1xBXTNtyDs3py7dCa+aEVSPTvGcdBZwmUdq70XW/RLot8LvpxN+PxCz+pCHi RH5VbYgnj9P0nDh6XCee/y1sHUjBsqbmVDjUk4rfqjxR75TwnLu9zfgyqjMAYoY8Q2Rh HBUFD24+XFRBMQjctwNd8V+8326IpO0I1ZxK96t5jk4EcG8JOpiqErOZj78OLHEQaneE nqXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=RD4vYSiyGfWfM8+zBSilB1VFrlPVw0KeRxNFGzToHPQ=; b=mkc8VMdqwOzaN82v7DdrRMQTrUShpOE41nzhr+dUl0OUnus1E/CYASLt/AXlPm06AC 3WwgJz8BDeWgSUdD2rTuq3mjeY5J0KQp6JKESRejd9Sg8pppDIP7e/mTV4PbdCWvohSW kGos/h3wr+MbOSdkWJTuD/ziCURtm3CYQ3XRtMXESawElHexqEk4qZUfLryi/eHjyBHy 3/yMrz7W2SkmNKV2/R1DVohdBW1TgX+iLb0D/0Hs+tiNx8H4LYM7xBMyDQixB2DBohsQ MHmGsLiEEzYYbjo9HdKDDi/ZpxXFfIY01skhIFOjjyGbOqjcAPdVvmSqTHlkq52wsh5g hPTg== X-Gm-Message-State: AJaThX5VivhuNBaN9isV2g/mpE80OKqa9KJxODz2zK/CcbW/Lk/3hzOb i/tuU3sB4Fmupg3AKrgmfqU= X-Google-Smtp-Source: AGs4zMaYtj5DDazpIS9Hfbhsnp8Ca7qjQMUBKOvXbNlXq6JNiYqG+X1clrpg/809uyRJCpBf6ZcccA== X-Received: by 10.98.198.28 with SMTP id m28mr429258pfg.217.1510806545068; Wed, 15 Nov 2017 20:29:05 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.29.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:29:04 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 05/12] isdn: hisax: Fix pnp_irq's error checking for setup_hfcsx Date: Thu, 16 Nov 2017 09:57:22 +0530 Message-Id: X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/hfc_sx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/hfc_sx.c b/drivers/isdn/hisax/hfc_sx.c index 3aef8e1..99f5a93 100644 --- a/drivers/isdn/hisax/hfc_sx.c +++ b/drivers/isdn/hisax/hfc_sx.c @@ -1422,7 +1422,7 @@ int setup_hfcsx(struct IsdnCard *card) } card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1]) { + if (card->para[0] == -1 || !card->para[1]) { printk(KERN_ERR "HFC PnP:some resources are missing %ld/%lx\n", card->para[0], card->para[1]); pnp_disable_dev(pnp_d);