From patchwork Sun Nov 5 09:59:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasily Averin X-Patchwork-Id: 834286 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yVB4R2lXsz9t38 for ; Sun, 5 Nov 2017 20:59:35 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752263AbdKEJ71 (ORCPT ); Sun, 5 Nov 2017 04:59:27 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:16669 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752041AbdKEJ70 (ORCPT ); Sun, 5 Nov 2017 04:59:26 -0500 Received: from [172.16.24.21] (msk-vpn.virtuozzo.com [195.214.232.6]) by relay.sw.ru (8.13.4/8.13.4) with ESMTP id vA59xE9S032248; Sun, 5 Nov 2017 12:59:15 +0300 (MSK) From: Vasily Averin Subject: [PATCH 02/21] ppp: exit_net cleanup checks added To: netdev@vger.kernel.org Cc: linux-ppp@vger.kernel.org, Paul Mackerras Message-ID: Date: Sun, 5 Nov 2017 12:59:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Be sure that lists initialized in net_init hook were return to initial state Signed-off-by: Vasily Averin --- drivers/net/ppp/ppp_generic.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c index e365866..c9791bc 100644 --- a/drivers/net/ppp/ppp_generic.c +++ b/drivers/net/ppp/ppp_generic.c @@ -960,6 +960,10 @@ static __net_exit void ppp_exit_net(struct net *net) rtnl_unlock(); idr_destroy(&pn->units_idr); + WARN(!list_empty(&pn->all_channels), + "net %p exit: ppp all_channels list is not empty\n", net); + WARN(!list_empty(&pn->new_channels), + "net %p exit: ppp new_channels list is not empty\n", net); } static struct pernet_operations ppp_net_ops = {