diff mbox series

[02/21] ppp: exit_net cleanup checks added

Message ID	eec31e0a-3b8b-6197-56bf-b436a6bace2e@virtuozzo.com
State	Changes Requested, archived
Delegated to:	David Miller
Headers	show Return-Path: <netdev-owner@vger.kernel.org> From: Vasily Averin <vvs@virtuozzo.com> Subject: [PATCH 02/21] ppp: exit_net cleanup checks added To: netdev@vger.kernel.org Cc: linux-ppp@vger.kernel.org, Paul Mackerras <paulus@samba.org> Message-ID: <eec31e0a-3b8b-6197-56bf-b436a6bace2e@virtuozzo.com> Date: Sun, 5 Nov 2017 12:59:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk
Series	exit_net checks for objects initialized in net_init hook \| expand [00/21] exit_net checks for objects initialized in net_init hook [01/21] exit_net cleanup: geneve sock_list check [02/21] ppp: exit_net cleanup checks added [03/21] vxlan: exit_net cleanup checks added [04/21] netdev: exit_net cleanup check added [05/21] nfs4blocklayout: exit_net cleanup check added [06/21] nfs client: exit_net cleanup check added [07/21] fib_notifier: exit_net cleanup check added [08/21] fib_rules: exit_net cleanup check added [09/21] clusterip: exit_net cleanup check added [10/21] xfrm6_tunnel: exit_net cleanup check added [11/21] af_key: replace BUG_ON on WARN_ON in net_exit hook [12/21] l2tp: exit_net cleanup check added [13/21] nf_tables: exit_net cleanup check added [14/21] nfnetlink_log: exit_net cleanup check added [15/21] nfnetlink_gueue: exit_net cleanup check added [16/21] x_tables: exit_net cleanup check added [17/21] hashlimit: exit_net cleanup check added [18/21] recent: exit_net cleanup check added [19/21] packet: exit_net cleanup check added [20/21] phonet: exit_net cleanup check added [21/21] sunrpc: exit_net cleanup check added

Commit Message

Vasily Averin Nov. 5, 2017, 9:59 a.m. UTC

Be sure that lists initialized in net_init hook were return to initial state

Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
---
 drivers/net/ppp/ppp_generic.c | 4 ++++
 1 file changed, 4 insertions(+)

diff mbox series

Patch

diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
index e365866..c9791bc 100644
--- a/drivers/net/ppp/ppp_generic.c
+++ b/drivers/net/ppp/ppp_generic.c
@@ -960,6 +960,10 @@  static __net_exit void ppp_exit_net(struct net *net)
 	rtnl_unlock();
 
 	idr_destroy(&pn->units_idr);
+	WARN(!list_empty(&pn->all_channels),
+	     "net %p exit: ppp all_channels list is not empty\n", net);
+	WARN(!list_empty(&pn->new_channels),
+	     "net %p exit: ppp new_channels list is not empty\n", net);
 }
 
 static struct pernet_operations ppp_net_ops = {