From patchwork Wed May 29 15:33:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 247291 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 365772C034A for ; Thu, 30 May 2013 01:36:18 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759663Ab3E2PgN (ORCPT ); Wed, 29 May 2013 11:36:13 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:37934 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759621Ab3E2Pde (ORCPT ); Wed, 29 May 2013 11:33:34 -0400 Received: by mail-wi0-f179.google.com with SMTP id hq7so3632615wib.0 for ; Wed, 29 May 2013 08:33:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:in-reply-to:references:content-type:x-gm-message-state; bh=bt7k0a2HAp9GvcntxtqVnFL5WwQiMWQgzpXRWnwYIwo=; b=U07LBUkJpThvyS5Lq/Yhmg8abErmkpViWpcburcmUrSSQM5BvSt4R2Yiy5e4yAyfO2 OMr5+ecAas5cSe0TgT/ypJGjCgSwQWDRtFBfdNBo14uZMiH3buf2Ce7UqTsgWEpvzROe DWl4xUyEY59baTT2wsMBDr7At5rkYKAKaI5MggCHNkCGh6Y8SsEkZslJmWrDye/YoeDM gjqB1PXrW4rYoB1/NjFpvjbDNd05OGcALI6C0grR5csaWX2mhmUwBAbEZ1fVFJoZQaS8 mLzJRfcUzlvvlyfrAReJNN4Qir2fTu7TRIF5TPD4Duw5TjsUy2Hje6inN/SyiUP0NYQS 4PpA== X-Received: by 10.181.13.169 with SMTP id ez9mr1884156wid.8.1369841613388; Wed, 29 May 2013 08:33:33 -0700 (PDT) Received: from localhost (nat-63.starnet.cz. [178.255.168.63]) by mx.google.com with ESMTPSA id ca19sm31945483wib.3.2013.05.29.08.33.32 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Wed, 29 May 2013 08:33:32 -0700 (PDT) From: Michal Simek To: linux-kernel@vger.kernel.org Cc: Michal Simek , Michal Simek , Bill Pemberton , Greg Kroah-Hartman , netdev@vger.kernel.org Subject: [PATCH 06/11] net: emaclite: Report failures in mdio setup Date: Wed, 29 May 2013 17:33:06 +0200 Message-Id: X-Mailer: git-send-email 1.8.2.3 In-Reply-To: <131c9262c3094ee3c664bd729a66e0709ceae82c.1369841519.git.michal.simek@xilinx.com> References: <131c9262c3094ee3c664bd729a66e0709ceae82c.1369841519.git.michal.simek@xilinx.com> In-Reply-To: <131c9262c3094ee3c664bd729a66e0709ceae82c.1369841519.git.michal.simek@xilinx.com> References: <131c9262c3094ee3c664bd729a66e0709ceae82c.1369841519.git.michal.simek@xilinx.com> X-Gm-Message-State: ALoCoQldnIK7ohg+lb1Nf43DN/bB/yLr2vPDsxgLbcbkRgAA0mcArfYks/bNPYO6dSJRgpIOMopi Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Be more verbose when any problem happens. Signed-off-by: Michal Simek --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) -- 1.8.2.3 diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 919b983..a16dc35 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -852,8 +852,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) /* Don't register the MDIO bus if the phy_node or its parent node * can't be found. */ - if (!np) + if (!np) { + dev_err(dev, "Failed to register mdio bus.\n"); return -ENODEV; + } /* Enable the MDIO bus by asserting the enable bit in MDIO Control * register. @@ -862,8 +864,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) XEL_MDIOCTRL_MDIOEN_MASK); bus = mdiobus_alloc(); - if (!bus) + if (!bus) { + dev_err(dev, "Failed to allocal mdiobus\n"); return -ENOMEM; + } of_address_to_resource(np, 0, &res); snprintf(bus->id, MII_BUS_ID_SIZE, "%.8llx", @@ -879,8 +883,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) lp->mii_bus = bus; rc = of_mdiobus_register(bus, np); - if (rc) + if (rc) { + dev_err(dev, "Failed to register mdio bus.\n"); goto err_register; + } return 0;