From patchwork Tue Aug 6 13:53:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Edward Cree X-Patchwork-Id: 1142810 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=solarflare.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 462x1Y6kGbz9sN1 for ; Tue, 6 Aug 2019 23:53:37 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731749AbfHFNxh (ORCPT ); Tue, 6 Aug 2019 09:53:37 -0400 Received: from dispatch1-us1.ppe-hosted.com ([67.231.154.164]:45142 "EHLO dispatch1-us1.ppe-hosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726373AbfHFNxg (ORCPT ); Tue, 6 Aug 2019 09:53:36 -0400 X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id D0007400090; Tue, 6 Aug 2019 13:53:35 +0000 (UTC) Received: from [10.17.20.203] (10.17.20.203) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 6 Aug 2019 06:53:32 -0700 From: Edward Cree Subject: [PATCH v3 net-next 2/3] sfc: falcon: don't score irq moderation points for GRO To: David Miller CC: netdev , Eric Dumazet , References: Message-ID: Date: Tue, 6 Aug 2019 14:53:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Originating-IP: [10.17.20.203] X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24824.005 X-TM-AS-Result: No-1.346800-4.000000-10 X-TMASE-MatchedRID: tPgJh90SXxdAEjf8JRFbHLsHVDDM5xAP1JP9NndNOkVBV3GkrxX03XHU HCqTYbHtrdoLblq9S5p1WMYsMQ0A8TmzjEr3tKb/WZTeB0tqopv0Bx2652QDU5soi2XrUn/JyeM tMD9QOgBJeFvFlVDkf46HM5rqDwqtrtHa78HwPsmqGznjX21ZnG1uaw0okPgButU9m6Jj1C0YMg H7o10UzvxC3BgCWfzjVycaTrCv8s36vsELZAwRRtq1LO+X/2prF8WOpmrvCxtyCYeHQXFONn+Ia U6aARfSasRgksxQ/TKxL55a4VUWu2cjFnImzvyS X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-1.346800-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24824.005 X-MDID: 1565099616-nZysr-V6r7Os Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Same rationale as for sfc, except that this wasn't performance-tested. Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/falcon/rx.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/sfc/falcon/rx.c b/drivers/net/ethernet/sfc/falcon/rx.c index fd850d3d8ec0..05ea3523890a 100644 --- a/drivers/net/ethernet/sfc/falcon/rx.c +++ b/drivers/net/ethernet/sfc/falcon/rx.c @@ -424,7 +424,6 @@ ef4_rx_packet_gro(struct ef4_channel *channel, struct ef4_rx_buffer *rx_buf, unsigned int n_frags, u8 *eh) { struct napi_struct *napi = &channel->napi_str; - gro_result_t gro_result; struct ef4_nic *efx = channel->efx; struct sk_buff *skb; @@ -460,9 +459,7 @@ ef4_rx_packet_gro(struct ef4_channel *channel, struct ef4_rx_buffer *rx_buf, skb_record_rx_queue(skb, channel->rx_queue.core_index); - gro_result = napi_gro_frags(napi); - if (gro_result != GRO_DROP) - channel->irq_mod_score += 2; + napi_gro_frags(napi); } /* Allocate and construct an SKB around page fragments */