From patchwork Wed Nov 25 01:16:05 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: andrew hendry X-Patchwork-Id: 39258 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id A84E7B6F04 for ; Wed, 25 Nov 2009 12:16:48 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934064AbZKYBQB (ORCPT ); Tue, 24 Nov 2009 20:16:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933964AbZKYBQA (ORCPT ); Tue, 24 Nov 2009 20:16:00 -0500 Received: from mail-pw0-f42.google.com ([209.85.160.42]:60509 "EHLO mail-pw0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933665AbZKYBP7 (ORCPT ); Tue, 24 Nov 2009 20:15:59 -0500 Received: by pwi3 with SMTP id 3so4538154pwi.21 for ; Tue, 24 Nov 2009 17:16:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:cc:content-type; bh=rLaCySPxkp8XxnTwF9HwGTcBTNKPEYIRxe7io5IupLA=; b=BN/M++mqrD/5PjnzBV2RV2yQxv35ZuoYXF6kzjziXzK13ngaBJhfZrff/NsIr4MxYz 4xsSl5pb8QeaqwIb+EndVcA0J5VVt66oQQTQLj58B1GZN5niVlLrTW8Je2R5APP416+4 yPTPQmMxlTVFVgW2DWlK6L/QW/LbU0dPuFu+w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:cc:content-type; b=GpFYk+G6gplDyQaEVJkEh6TCUnxi9KyfYhsxfZ1zO8TvEQnd0aCoWAXj9KmdVkO7Oq +uYAgjNBCMDTO0PRI9xQMRLQ2Ce0O08WjhPRlijXYHtlWbrYvFiprksbbV0JZMH414YQ vYEiQgkELMOg/yAsq+FgD40uiZ389stIgamJk= MIME-Version: 1.0 Received: by 10.142.60.5 with SMTP id i5mr751261wfa.102.1259111765643; Tue, 24 Nov 2009 17:16:05 -0800 (PST) Date: Wed, 25 Nov 2009 12:16:05 +1100 Message-ID: Subject: [PATCH 3/3] X25: Fix oops and refcnt problems from x25_dev_get From: andrew hendry To: netdev@vger.kernel.org Cc: linux-kernel , linux-x25@vger.kernel.org Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Calls to x25_dev_get check for dev = NULL which was not set. It allowed x25 to set routes and ioctls on down interfaces. This caused oopses and refcnt problems on device_unregister. Signed-off-by: Andrew Hendry --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/net/x25/x25_route.c 2009-11-25 09:30:52.003038597 +1100 +++ b/net/x25/x25_route.c 2009-11-25 09:33:37.627093701 +1100 @@ -136,8 +136,10 @@ struct net_device *x25_dev_get(char *dev #if defined(CONFIG_LLC) || defined(CONFIG_LLC_MODULE) && dev->type != ARPHRD_ETHER #endif - ))) + ))){ dev_put(dev); + dev = NULL; + } return dev; }