Message ID | d1e8daa3291f303bd581b89eae6e4003f2ee58a8.1500285278.git.sean.wang@mediatek.com |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
On Mon, Jul 17, 2017 at 06:06:22PM +0800, sean.wang@mediatek.com wrote: > From: Sean Wang <sean.wang@mediatek.com> > > The patch adds the supplements in the dt-binding document for MediaTek > MT7622 SoC with extra SGMII system controller and relevant clock consumers > listed as the requirements for those SoCs equipped with the SGMII circuit. > Also, add the missing binding information for MT7623 SoC here which relies > on the fallback binding of MT2701. > > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > --- > Documentation/devicetree/bindings/net/mediatek-net.txt | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt > index c7194e8..1d1168b 100644 > --- a/Documentation/devicetree/bindings/net/mediatek-net.txt > +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt > @@ -7,24 +7,30 @@ have dual GMAC each represented by a child node.. > * Ethernet controller node > > Required properties: > -- compatible: Should be "mediatek,mt2701-eth" > +- compatible: Should be > + "mediatek,mt2701-eth": for MT2701 SoC > + "mediatek,mt7623-eth", "mediatek,mt2701-eth": for MT7623 SoC Hi Sean We appear to have "mediatek,mt2701-eth" twice. Andrew
On Mon, 2017-07-17 at 15:38 +0200, Andrew Lunn wrote: > On Mon, Jul 17, 2017 at 06:06:22PM +0800, sean.wang@mediatek.com wrote: > > From: Sean Wang <sean.wang@mediatek.com> > > > > The patch adds the supplements in the dt-binding document for MediaTek > > MT7622 SoC with extra SGMII system controller and relevant clock consumers > > listed as the requirements for those SoCs equipped with the SGMII circuit. > > Also, add the missing binding information for MT7623 SoC here which relies > > on the fallback binding of MT2701. > > > > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > > --- > > Documentation/devicetree/bindings/net/mediatek-net.txt | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt > > index c7194e8..1d1168b 100644 > > --- a/Documentation/devicetree/bindings/net/mediatek-net.txt > > +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt > > @@ -7,24 +7,30 @@ have dual GMAC each represented by a child node.. > > * Ethernet controller node > > > > Required properties: > > -- compatible: Should be "mediatek,mt2701-eth" > > +- compatible: Should be > > + "mediatek,mt2701-eth": for MT2701 SoC > > + "mediatek,mt7623-eth", "mediatek,mt2701-eth": for MT7623 SoC > > Hi Sean > > We appear to have "mediatek,mt2701-eth" twice. > Hi, Andrew mt7623-eth supported up to now currently rely on the fallback binding of mt2701-eth in fact, the logic could be commonly found in many driver such as mtk sysirq such as [1] did, so i felt this usage should not make something wrong. [1] https://patchwork.kernel.org/patch/9739827/ > Andrew
diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt index c7194e8..1d1168b 100644 --- a/Documentation/devicetree/bindings/net/mediatek-net.txt +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt @@ -7,24 +7,30 @@ have dual GMAC each represented by a child node.. * Ethernet controller node Required properties: -- compatible: Should be "mediatek,mt2701-eth" +- compatible: Should be + "mediatek,mt2701-eth": for MT2701 SoC + "mediatek,mt7623-eth", "mediatek,mt2701-eth": for MT7623 SoC + "mediatek,mt7622-eth": for MT7622 SoC - reg: Address and length of the register set for the device - interrupts: Should contain the three frame engines interrupts in numeric order. These are fe_int0, fe_int1 and fe_int2. - clocks: the clock used by the core - clock-names: the names of the clock listed in the clocks property. These are - "ethif", "esw", "gp2", "gp1" + "ethif", "esw", "gp2", "gp1" : For MT2701 and MT7623 SoC + "ethif", "esw", "gp0", "gp1", "gp2", "sgmii_tx250m", "sgmii_rx250m", + "sgmii_cdr_ref", "sgmii_cdr_fb", "sgmii_ck", "eth2pll" : For MT7622 SoC - power-domains: phandle to the power domain that the ethernet is part of - resets: Should contain a phandle to the ethsys reset signal - reset-names: Should contain the reset signal name "eth" - mediatek,ethsys: phandle to the syscon node that handles the port setup +- mediatek,sgmiisys: phandle to the syscon node that handles the SGMII setup + which is required for those SoCs equipped with SGMII such as MT7622 SoC. - mediatek,pctl: phandle to the syscon node that handles the ports slew rate and driver current Optional properties: - interrupt-parent: Should be the phandle for the interrupt controller that services interrupts for this device - * Ethernet MAC node Required properties: