From patchwork Mon Aug 7 13:44:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geliang Tang X-Patchwork-Id: 798638 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ieCStE2+"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xQzLc0Nbdz9t1t for ; Mon, 7 Aug 2017 23:45:28 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752014AbdHGNo6 (ORCPT ); Mon, 7 Aug 2017 09:44:58 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:37063 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751857AbdHGNoy (ORCPT ); Mon, 7 Aug 2017 09:44:54 -0400 Received: by mail-lf0-f68.google.com with SMTP id x16so362483lfb.4; Mon, 07 Aug 2017 06:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LkY3JHbxSOniLeh5IJb797Z1zGmyyzLD1HlZra8yGZs=; b=ieCStE2+kXR5UEipIvJOsPpv2cgFD8BS5mBS2sv5bMFVhzfOBr03PgdbbbpW2U/+8N Wm4VzrQFt6UfoLPi3dVivepUh8owe+aRaiUmq8GvdtxbDMBK0UyPpW2B3mZcCv4ZtJ0j UJk61cSTZHs47a6HKGpmwIiZW8tXcVASFTAVsBWkHyAK2+JyqjhFX6I3JGNVB+chw2K/ roCnREDyY8Ezba3c2GODs2sY++DZBdLPr8pJzU/aA4T+gw1M4tUxBvpGRLpX5/kn3s30 9REvF32HdNcYjK7a6+5Lnb8w6+/Y7UH2y3nK07Oj0UUSUzCsns4adL9JesbgO5cvn9lQ Gb8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LkY3JHbxSOniLeh5IJb797Z1zGmyyzLD1HlZra8yGZs=; b=Sgy6iQ9U9j6+PkXVdGrdOO7aHYh5LHXwUetf5iBCdm15WImGZHN3Ef44u0yn31yWSN ksUABMB+YFS/eR+WcKBJyQaRD22/Hu/bmBBihCWgK9rzjOXJ8+fdW4P9ZSt5OO7XIf5q MvRjId8d+zLShacxcfSoPsT+fKLfGvXOMJolXPC7Wl17JwV7dGtRszgIYusfu4Z2l7rj GRzmRjXtqdWG3xhcGH5XuxLSJGLrouJo63gBXwIFGsitosLwtgEXRWWBp7DdAxlG8fCf Oumj1Pn8591jY30tRjpepzw7W+aUKvV0kUnux3cdETrKaXcNXG9SfW32Pxtg/zysxIi8 yiyg== X-Gm-Message-State: AHYfb5hDW+IqbHO+t0McDXFp/QTRnZ+++xQcTEXi8bY18MaGw6NouBXU gpAnKyA4ckIiww== X-Received: by 10.46.32.41 with SMTP id g41mr194431ljg.96.1502113493216; Mon, 07 Aug 2017 06:44:53 -0700 (PDT) Received: from localhost ([162.211.125.117]) by smtp.gmail.com with ESMTPSA id 1sm1980152ljn.38.2017.08.07.06.44.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Aug 2017 06:44:52 -0700 (PDT) From: Geliang Tang To: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" Cc: Geliang Tang , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] netfilter: xtables: use audit_log() Date: Mon, 7 Aug 2017 21:44:26 +0800 Message-Id: X-Mailer: git-send-email 2.11.0 In-Reply-To: <5f901760510d0dc6e6e971d4136c8d2d4e0a13fd.1502103408.git.geliangtang@gmail.com> References: <5f901760510d0dc6e6e971d4136c8d2d4e0a13fd.1502103408.git.geliangtang@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use audit_log() instead of open-coding it. Signed-off-by: Geliang Tang --- net/netfilter/x_tables.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c index e164823..c83a3b5 100644 --- a/net/netfilter/x_tables.c +++ b/net/netfilter/x_tables.c @@ -1192,16 +1192,10 @@ xt_replace_table(struct xt_table *table, #ifdef CONFIG_AUDIT if (audit_enabled) { - struct audit_buffer *ab; - - ab = audit_log_start(current->audit_context, GFP_KERNEL, - AUDIT_NETFILTER_CFG); - if (ab) { - audit_log_format(ab, "table=%s family=%u entries=%u", - table->name, table->af, - private->number); - audit_log_end(ab); - } + audit_log(current->audit_context, GFP_KERNEL, + AUDIT_NETFILTER_CFG, + "table=%s family=%u entries=%u", + table->name, table->af, private->number); } #endif