From patchwork Thu Nov 16 04:27:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838406 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kBO1o9hb"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpDz1q7vz9s7g for ; Thu, 16 Nov 2017 15:29:55 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758885AbdKPE3v (ORCPT ); Wed, 15 Nov 2017 23:29:51 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:44888 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932446AbdKPE3R (ORCPT ); Wed, 15 Nov 2017 23:29:17 -0500 Received: by mail-pg0-f67.google.com with SMTP id 4so10791502pge.1; Wed, 15 Nov 2017 20:29:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=3DZpcFVmM7AVNQ/tpF5oL6g3acrRbTdDfkmZdv6xfNM=; b=kBO1o9hbmnFbONZ7Y5CP2Net7j8hf+HltfyJ1aMSfL3abc8fx2amdbm1+tJnlDApNy MLPW39mBryKj21oFHxFwWVDI0qsHjrWrTFUhRc/Gk51JXEki/vkFK42gTRygpaBPRXX+ HkXRTwSGxArTyjrqr9oJ1RhRPyVgMCBDngI4mwv4yBl4o8iUGZljFLDkgC5cNvQax8ny xVLGPh0Bpc6ZGJnq6nix7zQsQMaD97qOGsQazc6ysIgq+OeU7ZhWfXn/jaizA1e3rI2A ROvVdGqMeTlspG5aBTV4FGCndxhhGkzvhStwdJuLJMHgPc8LH4l7Dp3frvbwXZzodEIa /w4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=3DZpcFVmM7AVNQ/tpF5oL6g3acrRbTdDfkmZdv6xfNM=; b=Q/fMuWu9pHUFoFCirfBOfTIOr8qPh97+lWmUD8742UcZgkO5C8ySNXS+y1CytgjmbD 3bhMPXWPskLrkgDPBksKJaZOmO9MYVW/8pZYpEdx9Q8VsSdR5hiKDKLrYO9QSFFFIHQ2 yzh+odLWUQuN1gCUpYf/NNgqcVxGhDO7+4EV1+50jram0XVeutHAJUhBRBCwsuHTyRjH 6vA/Y6YGZaHWwh2frdT9fFzWV+gDGdYlylzmoq9jbZ8lhuSqfoJvQEipGofU9vNYAfuF gznmVxjoWg0mdp0kPWplPRPGLgZX5A78gVhIRDVopbx0Ub16II3k/A2AsFsayIMrf+9y +VbA== X-Gm-Message-State: AJaThX5PyZjdZFA6WjTf6YGFzwm9fy2A8bEUYcVniXkC5lAete8TwE5d GFvDj4j09FJQr9pk1EHZwCg= X-Google-Smtp-Source: AGs4zMbr/3mYjtXHEonUB8jAn4opxv0MgwTp+eR5hB9zmhjpTjTDl1EGGGzRab2Aw62SY6K85+If8Q== X-Received: by 10.159.254.12 with SMTP id r12mr430436pls.218.1510806555949; Wed, 15 Nov 2017 20:29:15 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.29.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:29:15 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 09/12] isdn: hisax: Fix pnp_irq's error checking for setup_ix1micro Date: Thu, 16 Nov 2017 09:57:26 +0530 Message-Id: X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/ix1_micro.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/ix1_micro.c b/drivers/isdn/hisax/ix1_micro.c index 7ae39f5..bfb79f3 100644 --- a/drivers/isdn/hisax/ix1_micro.c +++ b/drivers/isdn/hisax/ix1_micro.c @@ -256,7 +256,7 @@ int setup_ix1micro(struct IsdnCard *card) } card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1]) { + if (card->para[0] == -1 || !card->para[1]) { printk(KERN_ERR "ITK PnP:some resources are missing %ld/%lx\n", card->para[0], card->para[1]); pnp_disable_dev(pnp_d);