From patchwork Sat May 6 15:42:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geliang Tang X-Patchwork-Id: 759330 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wKtP13vjPz9s7g for ; Sun, 7 May 2017 01:44:37 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kS3gVVXU"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753813AbdEFPoP (ORCPT ); Sat, 6 May 2017 11:44:15 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33175 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754603AbdEFPmw (ORCPT ); Sat, 6 May 2017 11:42:52 -0400 Received: by mail-pg0-f68.google.com with SMTP id s62so4604759pgc.0; Sat, 06 May 2017 08:42:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pKlcWIbomkIclXBENe7UHiXTqrSYkRrGwKa+Y8JchlQ=; b=kS3gVVXU2dyPV45CoqF6iFtjlnW31lQ+UpCX9yL475/5HmlC0Ll/AmxJEsGiZQG43G Lputtpo3cMVFBtj2rX0t9cyFD8/oUH85UtelQyw1jQFolMPj8SHrjzcDvs8VsrOqFnAt 8W3tONUjLDbN5xCrQnJ+Y0tk0BTmTmi/GBBLbLYRwA3QV6rI2C+eV0AqbJ71JyAOQ+WV tJjW9fch2wCFN+pUKX/0QEOPZs9FZgW8tK7yyUlDhGITeKI9h1K4dw593WRzlnoTO9D5 6z8LimRewCaJaVPgok3W/kCVjCbotNkC+/VlR8VlHsxAh8mhmewDNpHYdVMxx6156D02 q9sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pKlcWIbomkIclXBENe7UHiXTqrSYkRrGwKa+Y8JchlQ=; b=fioj/zA6mzoPYxmNdg5//U7mIGsT1uK5JCSsEFhDxTFIElP/7gK136CtXKV75akJWO 3syHv7/3eUfnrULcbvnv8hLxpn51SuMcS81RLTBPgwySp0HInok35qDH+ozh8FPqpzjU 5aFAHNvzR8L4mXXDiiccwVqY0rEgaUmzc/nwdjsB+x/JZJpe55aBGENyQjGzb21rgRDs 0iSqh06898e7V7igjzh7d2TPGStZW/VFSTCufOc5v7MxHLs9xtV4+F4KoLDvf36Rmxq7 zKhmpI8HCpXsFL2i6nwZqrtUiGyDirBhMGXj7P3C0U+gZePdO5qplAURDf0TvBiJ+uOp ujfA== X-Gm-Message-State: AN3rC/4Z66YFfUXCKhGtDI+03ZQQ1nJaLGFdA8ZN8PTm93CYyYUuxUIt VCZxxziH+yL33w== X-Received: by 10.99.123.94 with SMTP id k30mr9463016pgn.91.1494085372092; Sat, 06 May 2017 08:42:52 -0700 (PDT) Received: from localhost (li409-196.members.linode.com. [106.187.89.196]) by smtp.gmail.com with ESMTPSA id p62sm13734781pfp.48.2017.05.06.08.42.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 06 May 2017 08:42:51 -0700 (PDT) From: Geliang Tang To: Maya Erez , Kalle Valo Cc: Geliang Tang , linux-wireless@vger.kernel.org, wil6210@qca.qualcomm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] wil6210: use memdup_user Date: Sat, 6 May 2017 23:42:19 +0800 Message-Id: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- drivers/net/wireless/ath/wil6210/debugfs.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c b/drivers/net/wireless/ath/wil6210/debugfs.c index 5648ebb..5b0f9fc 100644 --- a/drivers/net/wireless/ath/wil6210/debugfs.c +++ b/drivers/net/wireless/ath/wil6210/debugfs.c @@ -795,15 +795,11 @@ static ssize_t wil_write_file_txmgmt(struct file *file, const char __user *buf, struct wireless_dev *wdev = wil_to_wdev(wil); struct cfg80211_mgmt_tx_params params; int rc; - void *frame = kmalloc(len, GFP_KERNEL); + void *frame; - if (!frame) - return -ENOMEM; - - if (copy_from_user(frame, buf, len)) { - kfree(frame); - return -EIO; - } + frame = memdup_user(buf, len); + if (IS_ERR(frame)) + return PTR_ERR(frame); params.buf = frame; params.len = len;