Message ID | alpine.LRH.2.00.1007190958480.9943@localhost.localdomain |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Shreyas Bhatewara <sbhatewara@vmware.com> Date: Mon, 19 Jul 2010 10:02:13 -0700 (PDT) > Hold rtnl_lock to get the right link state. > > While asynchronously resetting the device, hold rtnl_lock to get the > right value from netif_running. If a reset is scheduled, and the device > goes thru close and open, it may happen that reset and open may run in > parallel. Holding rtnl_lock will avoid this. > > Signed-off-by: Shreyas Bhatewara <sbhatewara@vmware.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index 1b0ce8c..c4d7e42 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -2420,6 +2420,7 @@ vmxnet3_reset_work(struct work_struct *data) return; /* if the device is closed, we must leave it alone */ + rtnl_lock(); if (netif_running(adapter->netdev)) { printk(KERN_INFO "%s: resetting\n", adapter->netdev->name); vmxnet3_quiesce_dev(adapter); @@ -2428,6 +2429,7 @@ vmxnet3_reset_work(struct work_struct *data) } else { printk(KERN_INFO "%s: already closed\n", adapter->netdev->name); } + rtnl_unlock(); clear_bit(VMXNET3_STATE_BIT_RESETTING, &adapter->state); }