From patchwork Mon Jan 2 21:40:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Engelhardt X-Patchwork-Id: 133919 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 51407B6FA9 for ; Tue, 3 Jan 2012 08:40:34 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753338Ab2ABVkM (ORCPT ); Mon, 2 Jan 2012 16:40:12 -0500 Received: from seven.medozas.de ([188.40.89.202]:37395 "EHLO seven.medozas.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753185Ab2ABVkK (ORCPT ); Mon, 2 Jan 2012 16:40:10 -0500 Received: by seven.medozas.de (Postfix, from userid 25121) id 78A9421A0316; Mon, 2 Jan 2012 22:40:09 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by seven.medozas.de (Postfix) with ESMTP id 4354A21A0314; Mon, 2 Jan 2012 22:40:09 +0100 (CET) Date: Mon, 2 Jan 2012 22:40:09 +0100 (CET) From: Jan Engelhardt To: Pablo Neira Ayuso cc: netfilter@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, netfilter-announce@lists.netfilter.org, lwn@lwn.net Subject: Re: [ANNOUNCE] libnetfilter_queue 1.0.1 release In-Reply-To: Message-ID: References: <20120102195845.GA26867@1984> User-Agent: Alpine 2.01 (LNX 1266 2009-07-14) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Monday 2012-01-02 22:22, Jan Engelhardt wrote: >On Monday 2012-01-02 20:58, Pablo Neira Ayuso wrote: > >>Hi! >> >>The Netfilter project proudly presents: >> >> libnetfilter_queue 1.0.1 > >In commit 390b0c0f45597c72fa93a40f4f7f9ffeec371f42 >Author: Pablo Neira Ayuso >Date: Mon Jan 2 20:28:45 2012 +0100 > > build: bump version to 1.0.1 > > Signed-off-by: Pablo Neira Ayuso > >diff --git a/src/Makefile.am b/src/Makefile.am >index 0bd037f..bc27625 100644 >--- a/src/Makefile.am >+++ b/src/Makefile.am >@@ -18,7 +18,7 @@ > # set age to 0. > # > # >-LIBVERSION=2:0:1 >+LIBVERSION=2:0:2 > > include ${top_srcdir}/Make_global.am > > >You wrongly changed LIBVERSION. It went from .so.1.1 to so.0.2, and that >just does not sound right. Perhaps you intended 2:1:1. > >Or just leaving r alone, like proposed? :) Upon closer review, you ought to select 3:0:2, since you added functions since libnetfilter_queue-1.0.0. === origin git://dev.medozas.de/libnetfilter_queue master parent 390b0c0f45597c72fa93a40f4f7f9ffeec371f42 (libnetfilter_queue-1.0.1) commit a192d817a16ba08193a90043b46b6e2cf2d05091 Author: Jan Engelhardt Date: Mon Jan 2 22:36:03 2012 +0100 build: properly bump SO version The last SO version update was bogus: 2:0:1 (.so.1.1.0) -> 2:0:2 (.so.0.2.0). Since two functions were added between v1.0.0..v1.0.1, CURRENT needs to be bumped at the least. Signed-off-by: Jan Engelhardt --- src/Makefile.am | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index bc27625..d49e738 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -18,7 +18,7 @@ # set age to 0. # # -LIBVERSION=2:0:2 +LIBVERSION=3:0:2 include ${top_srcdir}/Make_global.am