From patchwork Wed Jan 12 20:57:31 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Engelhardt X-Patchwork-Id: 78614 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 1816EB6F10 for ; Thu, 13 Jan 2011 07:57:40 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756405Ab1ALU5e (ORCPT ); Wed, 12 Jan 2011 15:57:34 -0500 Received: from borg.medozas.de ([188.40.89.202]:33012 "EHLO borg.medozas.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753457Ab1ALU5c (ORCPT ); Wed, 12 Jan 2011 15:57:32 -0500 Received: by borg.medozas.de (Postfix, from userid 25121) id 38BEAF0B8C960; Wed, 12 Jan 2011 21:57:31 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by borg.medozas.de (Postfix) with ESMTP id 2D61F2424; Wed, 12 Jan 2011 21:57:31 +0100 (CET) Date: Wed, 12 Jan 2011 21:57:31 +0100 (CET) From: Jan Engelhardt To: Pablo Neira Ayuso cc: Valdis.Kletnieks@vt.edu, Patrick McHardy , "David S. Miller" , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: XT_MATCH_REALM Kconfig whinge... In-Reply-To: <4D2E057D.30707@netfilter.org> Message-ID: References: <20519.1294859715@localhost> <4D2E057D.30707@netfilter.org> User-Agent: Alpine 2.01 (LNX 1266 2009-07-14) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wednesday 2011-01-12 20:48, Pablo Neira Ayuso wrote: >On 12/01/11 20:15, Valdis.Kletnieks@vt.edu wrote: >> scripts/kconfig/conf --silentoldconfig Kconfig >> warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED) >> warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED) > >Does this fix your problem? > This patch is not right. The select should just be removed, because xt_realm is useful even without SCHED and CLS_ROUTE. --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig index 1534f2b..ae56764 100644 --- a/net/netfilter/Kconfig +++ b/net/netfilter/Kconfig @@ -886,7 +886,8 @@ config NETFILTER_XT_MATCH_RATEEST config NETFILTER_XT_MATCH_REALM tristate '"realm" match support' depends on NETFILTER_ADVANCED - select NET_CLS_ROUTE + depends on NET_SCHED + depends on NET_CLS_ROUTE help This option adds a `realm' match, which allows you to use the realm key from the routing subsystem inside iptables.