From patchwork Mon Sep 30 19:25:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Juhl X-Patchwork-Id: 279215 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D7AE72C011C for ; Tue, 1 Oct 2013 05:34:34 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756160Ab3I3TeR (ORCPT ); Mon, 30 Sep 2013 15:34:17 -0400 Received: from swampdragon.chaosbits.net ([90.184.90.115]:47693 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755258Ab3I3TeP (ORCPT ); Mon, 30 Sep 2013 15:34:15 -0400 X-Greylist: delayed 527 seconds by postgrey-1.27 at vger.kernel.org; Mon, 30 Sep 2013 15:34:15 EDT Received: by swampdragon.chaosbits.net (Postfix, from userid 1000) id D47A09403D; Mon, 30 Sep 2013 21:25:27 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by swampdragon.chaosbits.net (Postfix) with ESMTP id C7B679403B; Mon, 30 Sep 2013 21:25:27 +0200 (CEST) Date: Mon, 30 Sep 2013 21:25:27 +0200 (CEST) From: Jesper Juhl To: Armin Schindler cc: Karsten Keil , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] isdn: eicon: free pointer after using it in log msg in divas_um_idi_delete_entity() Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Not really a problem, but nice IMHO; the Coverity static analyzer complains that we use the pointer 'e' after it has been freed, so move the freeing below the final use, even if that use is just using the value of the pointer and not actually dereferencing it. Signed-off-by: Jesper Juhl --- drivers/isdn/hardware/eicon/um_idi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- 1.7.1 diff --git a/drivers/isdn/hardware/eicon/um_idi.c b/drivers/isdn/hardware/eicon/um_idi.c index 7cab5c3..e151971 100644 --- a/drivers/isdn/hardware/eicon/um_idi.c +++ b/drivers/isdn/hardware/eicon/um_idi.c @@ -288,9 +288,9 @@ int divas_um_idi_delete_entity(int adapter_nr, void *entity) cleanup_entity(e); diva_os_free(0, e->os_context); memset(e, 0x00, sizeof(*e)); - diva_os_free(0, e); DBG_LOG(("A(%d) remove E:%08x", adapter_nr, e)); + diva_os_free(0, e); return (0); }