From patchwork Wed Dec 26 20:51:12 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Juhl X-Patchwork-Id: 208217 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9D4E32C00BD for ; Thu, 27 Dec 2012 07:51:22 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754167Ab2LZUvQ (ORCPT ); Wed, 26 Dec 2012 15:51:16 -0500 Received: from swampdragon.chaosbits.net ([90.184.90.115]:50391 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537Ab2LZUvO (ORCPT ); Wed, 26 Dec 2012 15:51:14 -0500 Received: by swampdragon.chaosbits.net (Postfix, from userid 1000) id 21DAF9403D; Wed, 26 Dec 2012 21:51:13 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by swampdragon.chaosbits.net (Postfix) with ESMTP id 19BC89403B; Wed, 26 Dec 2012 21:51:13 +0100 (CET) Date: Wed, 26 Dec 2012 21:51:12 +0100 (CET) From: Jesper Juhl To: linux-kernel@vger.kernel.org cc: wlanfae , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, "John W. Linville" , Chaoming Li , Larry Finger Subject: [PATCH] rtlwifi: Don't leak on error in _rtl_usb_receive() Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We fail to release 'urb' if '_rtl_prep_rx_urb()' fails in _rtl_usb_receive(). This patch should take care of the leak. Signed-off-by: Jesper Juhl Acked-by: Larry Finger --- drivers/net/wireless/rtlwifi/usb.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) note: compile tested only. diff --git a/drivers/net/wireless/rtlwifi/usb.c b/drivers/net/wireless/rtlwifi/usb.c index 29f0969..75c29e6 100644 --- a/drivers/net/wireless/rtlwifi/usb.c +++ b/drivers/net/wireless/rtlwifi/usb.c @@ -640,6 +640,7 @@ static int _rtl_usb_receive(struct ieee80211_hw *hw) RT_TRACE(rtlpriv, COMP_USB, DBG_EMERG, "Failed to prep_rx_urb!!\n"); err = PTR_ERR(skb); + usb_free_urb(urb); goto err_out; }