From patchwork Mon Apr 9 20:50:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Juhl X-Patchwork-Id: 151477 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6C31AB7023 for ; Tue, 10 Apr 2012 06:57:50 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756862Ab2DIU5e (ORCPT ); Mon, 9 Apr 2012 16:57:34 -0400 Received: from swampdragon.chaosbits.net ([90.184.90.115]:20873 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756769Ab2DIUuZ (ORCPT ); Mon, 9 Apr 2012 16:50:25 -0400 Received: by swampdragon.chaosbits.net (Postfix, from userid 1000) id 902599403D; Mon, 9 Apr 2012 22:50:24 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by swampdragon.chaosbits.net (Postfix) with ESMTP id 8DCF09403B; Mon, 9 Apr 2012 22:50:24 +0200 (CEST) Date: Mon, 9 Apr 2012 22:50:24 +0200 (CEST) From: Jesper Juhl To: linux-kernel@vger.kernel.org cc: trivial@kernel.org, netdev@vger.kernel.org, Rasesh Mody Subject: [PATCH 06/26] bna: remove redundant NULL test before release_firmware() In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org release_firmware() does its own NULL test so explicit test before call is unneeded. Signed-off-by: Jesper Juhl Acked-by: Rasesh Mody --- drivers/net/ethernet/brocade/bna/bnad.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c index ff78f77..d86390c 100644 --- a/drivers/net/ethernet/brocade/bna/bnad.c +++ b/drivers/net/ethernet/brocade/bna/bnad.c @@ -3546,9 +3546,7 @@ static void __exit bnad_module_exit(void) { pci_unregister_driver(&bnad_pci_driver); - - if (bfi_fw) - release_firmware(bfi_fw); + release_firmware(bfi_fw); } module_init(bnad_module_init);